Need to flatten forum threads

Author: Tom Copeland

README.rdoc

@@ -17,10 +17,6 @@ Migration FIXMEs
 * need to upgrade base redmine to latest release - 0.9.5
 * why does [email protected]/password have no issues here /my/page
 * need to populate activity, e.g., /projects/support/activity
-* some message threads have missing messages after migration, e.g.
-http://rubyforge.org/forum/message.php?msg_id=92
-vs
-http://localhost:3000/boards/1/topics/13
 
 Redmine FIXMEs
 * will need to modify Redmine auth to use MD5 since that's what GForge uses
@@ -58,6 +54,7 @@ Some notes on the differences between the GForge and the Redmine object models:
 * GForge stores the user language setting as a foreign key into the <tt>supported_languages</tt> table.  Redmine stores it as a two letter string (e.g., 'en') in <tt>users.language</tt>.
 * The GForge <tt>artifact_group_list</tt> table gets mapped into rows in the Redmine <tt>projects_trackers</tt> table (<tt>projects</tt> HABTM <tt>trackers</tt>).  Redmine <tt>trackers</tt> are not per <tt>project</tt>; they are shared for the whole system.  The current migration only provisions rows in the <tt>projects_trackers</tt> table as they are needed - e.g., a <tt>project</tt> won't get a "Bug" <tt>tracker</tt> unless there's a GForge <tt>artifact</tt> in a "Bug" GForge <tt>artifact_group_list</tt> in this project.  If there's a GForge <tt>artifact_group_list</tt> with an unexpected name (e.g., "Tom's Issues") those get mapped into the "Bug" <tt>tracker</tt>.
 * GForge <tt>artifacts</tt> have only three statuses (open/closed/deleted) whereas Redmine issues have six possible <tt>IssueStatus</tt> settings, so I just map them over to the <tt>IssueStatus</tt> with the same name.  GForge <tt>artifacts</tt> have five priority levels; these map onto Redmine's five standard <tt>IssueCategory</tt> values.
+* The GForge forum system handles nested message threads whereas Redmine forum threads are flat (<a href="http://www.redmine.org/boards/1/topics/15509">details</a>).  So there's some lost information there, but, meh.
 
 
 === GForge table to Redmine table mapping

lib/tasks/migrate_from_gforge.rake

@@ -99,7 +99,15 @@ namespace :redmine do
           end
           board_threads[forum_message.id] = message
           if forum_message.is_followup_to
-            message.parent = board_threads[forum_message.is_followup_to]
+            possible_parent = board_threads[forum_message.is_followup_to]
+            # Redmine has flat message replies, GForge has nested replies
+            # See http://www.redmine.org/boards/1/topics/15509 for more details
+            # So, flattening the GForge threads
+            if possible_parent && possible_parent.parent
+              message.parent = possible_parent.parent
+            else
+              message.parent = possible_parent
+            end
             message.save!
           end
         end