Skip to content

Commit ee740bf

Browse files
authored
Merge pull request #696 from junaruga/wip/doc-markdown-ref
Use Markdown reference-style links in documents. [ci skip]
2 parents f29b0e5 + 5cdaf26 commit ee740bf

File tree

2 files changed

+33
-31
lines changed

2 files changed

+33
-31
lines changed

CONTRIBUTING.md

+27-28
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Bugs and feature requests are tracked on [GitHub].
1010

1111
If you think you found a bug, file a ticket on GitHub. Please DO NOT report
1212
security issues here, there is a separate procedure which is described on
13-
["Security at ruby-lang.org"](https://www.ruby-lang.org/en/security/).
13+
["Security at ruby-lang.org"][Ruby Security].
1414

1515
When reporting a bug, please make sure you include:
1616

@@ -22,26 +22,25 @@ When reporting a bug, please make sure you include:
2222

2323
There are a number of unresolved issues and feature requests for openssl that
2424
need review. Before submitting a new ticket, it is recommended to check
25-
[known issues].
25+
[known issues][Issues].
2626

2727
## Submitting patches
2828

2929
Patches are also very welcome!
3030

31-
Please submit a [pull request] with your changes.
31+
Please submit a [pull request][Compare changes] with your changes.
3232

3333
Make sure that your branch does:
3434

3535
* Have good commit messages
36-
* Follow Ruby's coding style ([DeveloperHowTo])
36+
* Follow Ruby's coding style ([Developer-How-To][Ruby Developer-How-To])
3737
* Pass the test suite successfully (see "Testing")
3838

3939
## Testing
4040

4141
We have a test suite!
4242

43-
Test cases are located under the
44-
[`test/openssl`](https://github.com/ruby/openssl/tree/master/test/openssl)
43+
Test cases are located under the [`test/openssl`][GitHub test/openssl]
4544
directory.
4645

4746
You can run it with the following three commands:
@@ -58,9 +57,9 @@ Ruby OpenSSL supports various versions of the OpenSSL library. The test suite
5857
needs to pass on all supported combinations.
5958

6059
If you want to test, debug, report an issue, or contribute to the Ruby OpenSSL
61-
or [the OpenSSL project](https://www.openssl.org/) in the non-FIPS or
62-
the [FIPS](https://github.com/openssl/openssl/blob/master/README-FIPS.md) case,
63-
compiling OpenSSL from the source by yourself is a good practice.
60+
or [the OpenSSL project][OpenSSL] in the non-FIPS or the
61+
[FIPS][OpenSSL README-FIPS] case, compiling OpenSSL from the source by yourself
62+
is a good practice.
6463

6564
The following steps are tested in Linux and GCC environment. You can adjust the
6665
commands in the steps for a different environment.
@@ -104,20 +103,16 @@ $ OPENSSL_DIR=$HOME/.openssl/openssl-fips-debug-0bf18140f4
104103
```
105104

106105
The following configuration options are useful in this case.
107-
You can check
108-
[OpenSSL installation document](https://github.com/openssl/openssl/blob/master/INSTALL.md)
109-
for details.
106+
You can check [OpenSSL installation document][OpenSSL INSTALL] for details.
110107

111108
* `enable-fips`: Add an option to run with the OpenSSL FIPS module.
112109
* `enable-trace`: Add an option to enabling tracing log. You can trace logs by
113-
implementing a code. See the man page
114-
[OSSL_TRACE(3)](https://www.openssl.org/docs/man3.0/man3/OSSL_TRACE.html) for
110+
implementing a code. See the man page [OSSL_TRACE(3)][OpenSSL OSSL_TRACE] for
115111
details.
116112
* compiler flags
117113
* `-Wl,-rpath,$(LIBRPATH)`: Set the runtime shared library path to run the
118114
`openssl` command without the `LD_LIBRARY_PATH`. You can check
119-
[this document](https://github.com/openssl/openssl/blob/master/NOTES-UNIX.md)
120-
for details.
115+
[this document][OpenSSL NOTES-UNIX] for details.
121116
* `-O0 -g3 -ggdb3 -gdwarf-5`: You can set debugging compiler flags.
122117

123118
```
@@ -173,8 +168,7 @@ To use OpenSSL 3.0 or later versions in a FIPS-approved manner, you must load th
173168
property query is used when fetching cryptographic algorithm implementations.
174169
This must be done at the startup of a process to avoid implicitly loading the
175170
`default` provider which has the non-FIPS cryptographic algorithm
176-
implementations. See also the man page
177-
[fips_module(7)](https://www.openssl.org/docs/manmaster/man7/fips_module.html).
171+
implementations. See also the man page [fips_module(7)][OpenSSL fips_module].
178172

179173
You can set this in your OpenSSL configuration file by either appropriately
180174
modifying the default OpenSSL configuration file located at
@@ -227,10 +221,8 @@ $ OPENSSL_CONF=$OPENSSL_DIR/ssl/openssl_fips.cnf \
227221
bundle exec rake test
228222
```
229223

230-
The GitHub Actions workflow file
231-
[`test.yml`](https://github.com/ruby/openssl/tree/master/.github/workflows/test.yml)
232-
contains useful information for building OpenSSL/LibreSSL and testing against
233-
them.
224+
The GitHub Actions workflow file [`test.yml`][GitHub test.yml] contains useful
225+
information for building OpenSSL/LibreSSL and testing against them.
234226

235227

236228
## Relation with Ruby source tree
@@ -255,7 +247,7 @@ security issue handling procedure for Ruby core.
255247

256248
You can either use [HackerOne] or send an email to [email protected].
257249

258-
Please see [Security] page on ruby-lang.org website for details.
250+
Please see [Security][Ruby Security] page on ruby-lang.org website for details.
259251

260252
Reported problems will be published after a fix is released.
261253

@@ -264,9 +256,16 @@ _Thanks for your contributions!_
264256
_\- The Ruby OpenSSL team_
265257

266258
[GitHub]: https://github.com/ruby/openssl
267-
[known issues]: https://github.com/ruby/openssl/issues
268-
[DeveloperHowTo]: https://bugs.ruby-lang.org/projects/ruby/wiki/DeveloperHowto
259+
[Issues]: https://github.com/ruby/openssl/issues
260+
[Compare changes]: https://github.com/ruby/openssl/compare
261+
[GitHub test/openssl]: https://github.com/ruby/openssl/tree/master/test/openssl
262+
[GitHub test.yml]: https://github.com/ruby/openssl/tree/master/.github/workflows/test.yml
263+
[Ruby Developer-How-To]: https://github.com/ruby/ruby/wiki/Developer-How-To
264+
[Ruby Security]: https://www.ruby-lang.org/en/security/
269265
[HackerOne]: https://hackerone.com/ruby
270-
[Security]: https://www.ruby-lang.org/en/security/
271-
[pull request]: https://github.com/ruby/openssl/compare
272-
[History.md]: https://github.com/ruby/openssl/tree/master/History.md
266+
[OpenSSL]: https://www.openssl.org/
267+
[OpenSSL INSTALL]: https://github.com/openssl/openssl/blob/master/INSTALL.md
268+
[OpenSSL README-FIPS]: https://github.com/openssl/openssl/blob/master/README-FIPS.md
269+
[OpenSSL NOTES-UNIX]: https://github.com/openssl/openssl/blob/master/NOTES-UNIX.md
270+
[OpenSSL OSSL_TRACE]: https://www.openssl.org/docs/manmaster/man3/OSSL_TRACE.html
271+
[OpenSSL fips_module]: https://www.openssl.org/docs/manmaster/man7/fips_module.html

README.md

+6-3
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@ included as a default gem in [supported Ruby branches][Ruby Maintenance Branches
3232

3333
> **Note**
3434
> The openssl gem is included with Ruby by default, but you may wish to upgrade
35-
> it to a newer version available at
36-
> [rubygems.org](https://rubygems.org/gems/openssl).
35+
> it to a newer version available at [rubygems.org][RubyGems.org openssl].
3736
3837
To upgrade it, you can use RubyGems:
3938

@@ -59,6 +58,8 @@ gem 'openssl', git: 'https://github.com/ruby/openssl'
5958

6059
After running `bundle install`, you should have the gem installed in your bundle.
6160

61+
[RubyGems.org openssl]: https://rubygems.org/gems/openssl
62+
6263
## Usage
6364

6465
Once installed, you can require "openssl" in your application.
@@ -80,4 +81,6 @@ Please read our [CONTRIBUTING.md] for instructions.
8081
## Security
8182

8283
Security issues should be reported to ruby-core by following the process
83-
described on ["Security at ruby-lang.org"](https://www.ruby-lang.org/en/security/).
84+
described on ["Security at ruby-lang.org"][Security].
85+
86+
[Security]: https://www.ruby-lang.org/en/security/

0 commit comments

Comments
 (0)