Skip to content

Commit d68510b

Browse files
author
Tatsuya Sato
committed
Merge branch 'master' into bugfix/filter_parser_cannot_parse_blackets
Conflicts: lib/net/ldap/filter.rb spec/unit/ldap/filter_parser_spec.rb
2 parents bc45065 + 1dc2907 commit d68510b

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

72 files changed

+3486
-1880
lines changed

.autotest

Lines changed: 0 additions & 11 deletions
This file was deleted.

.gitignore

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
1-
spec/ldap.yml
1+
*~
2+
*.swp
23
.rvmrc
3-
*.gemspec
44
pkg/
5-
*.swp
6-
html/
75
doc/
86
publish/
9-
coverage/
10-
coverage.info
11-
.rake_tasks~
127
Gemfile.lock
8+
.bundle
9+
bin/

.rspec

Lines changed: 0 additions & 2 deletions
This file was deleted.

.travis.yml

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,27 @@ language: ruby
22
rvm:
33
- 1.9.3
44
- 2.0.0
5+
- 2.1.2
6+
# optional
57
- jruby-19mode
68
- rbx-19mode
7-
script: bundle exec rake spec
9+
- rbx-2
10+
11+
env:
12+
- INTEGRATION=openldap
13+
14+
install:
15+
- if [ "$INTEGRATION" = "openldap" ]; then ./script/install-openldap; fi
16+
- bundle install
17+
18+
script: bundle exec rake
19+
20+
matrix:
21+
allow_failures:
22+
- rvm: jruby-19mode
23+
- rvm: rbx-19mode
24+
- rvm: rbx-2
25+
fast_finish: true
26+
27+
notifications:
28+
email: false

CONTRIBUTING.md

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
# Contribution guide
2+
3+
Thank you for using net-ldap. If you'd like to help, keep these guidelines in
4+
mind.
5+
6+
## Submitting a New Issue
7+
8+
If you find a bug, or would like to propose an idea, file a [new issue][issues].
9+
Include as many details as possible:
10+
11+
- Version of net-ldap gem
12+
- LDAP server version
13+
- Queries, connection information, any other input
14+
- output or error messages
15+
16+
## Sending a Pull Request
17+
18+
[Pull requests][pr] are always welcome!
19+
20+
Check out [the project's issues list][issues] for ideas on what could be improved.
21+
22+
Before sending, please add tests and ensure the test suite passes.
23+
24+
To run the full suite:
25+
26+
`bundle exec rake`
27+
28+
To run a specific test file:
29+
30+
`bundle exec ruby test/test_ldap.rb`
31+
32+
To run a specific test:
33+
34+
`bundle exec ruby test/test_ldap.rb -n test_instrument_bind`
35+
36+
Pull requests will trigger automatic continuous integration builds on
37+
[TravisCI][travis]. To run integration tests locally, see the `test/support`
38+
folder.
39+
40+
## Styleguide
41+
42+
```ruby
43+
# 1.9+ style hashes
44+
{key: "value"}
45+
46+
# Multi-line arguments with `\`
47+
MyClass.new \
48+
foo: 'bar',
49+
baz: 'garply'
50+
```
51+
52+
[issues]: https://github.com/ruby-net-ldap/ruby-net-ldap/issues
53+
[pr]: https://help.github.com/articles/using-pull-requests
54+
[travis]: https://travis-ci.org/ruby-ldap/ruby-net-ldap

Hacking.rdoc

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ patches being accepted, we recommend that you follow the guidelines below:
2525

2626
== Documentation
2727

28-
* Documentation: {net-ldap}[http://net-ldap.rubyforge.org/]
28+
* Documentation: {net-ldap}[http://rubydoc.info/gems/net-ldap]
2929

3030
It is very important that, if you add new methods or objects, your code is
3131
well-documented. The purpose of the changes should be clearly described so that
@@ -40,8 +40,8 @@ modification to +Contributors.rdoc+ to add yourself.
4040

4141
== Tests
4242

43-
The Net::LDAP team uses RSpec for unit testing; all changes must have rspec
44-
tests for any new or changed features.
43+
The Net::LDAP team uses [Minitest](http://docs.seattlerb.org/minitest/) for unit
44+
testing; all changes must have tests for any new or changed features.
4545

4646
Your changes should have been tested against at least one real LDAP server; the
4747
current tests are not sufficient to find all possible bugs. It's unlikely that
@@ -55,14 +55,9 @@ us with a sample LDIF data file for importing into LDAP servers for testing.
5555
Net::LDAP uses several libraries during development, all of which can be
5656
installed using RubyGems.
5757

58-
* *hoe*
59-
* *hoe-git*
60-
* *metaid*
61-
* *rspec*
6258
* *flexmock*
6359

6460
== Participation
6561

66-
* RubyForge: {net-ldap}[http://rubyforge.org/projects/net-ldap]
6762
* GitHub: {ruby-ldap/ruby-net-ldap}[https://github.com/ruby-ldap/ruby-net-ldap/]
6863
* Group: {ruby-ldap}[http://groups.google.com/group/ruby-ldap]

History.rdoc

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,40 @@
1+
=== Net::LDAP 0.9.0
2+
* Major changes:
3+
* Dropped support for ruby 1.8.7, ruby >= 1.9.3 now required
4+
* Major enhancements:
5+
* Add support for search time limit parameter
6+
* Instrument received messages, PDU parsing
7+
* Minor enhancments:
8+
* Add support for querying ActiveDirectory capabilities from root dse
9+
* Bug fixes:
10+
* Fix reads for multiple concurrent requests with shared, open connections mixing up the results
11+
* Fix search size option
12+
* Fix BER encoding bug
13+
* Code clean-up:
14+
* Added integration test suite
15+
* Switch to minitest
16+
17+
* Details
18+
* #150 Support querying ActiveDirectory capabilities when searching root dse
19+
* #142 Encode true as xFF
20+
* #124, #145, #146, #152 Cleanup gemspec
21+
* #138, #144 Track response messages by message id
22+
* #141 Magic number/constant cleanup
23+
* #119, #129, #130, #132, #133, #137 Integration tests
24+
* #115 Search timeout support
25+
* #140 Fix search size option
26+
* #139 Cleanup and inline documentation for Net::LDAP::Connection#search
27+
* #131 Instrumentation
28+
* #116 Refactor Connection#write
29+
* #126 Update gitignore
30+
* #128 Fix whitespace
31+
* #113, #121 Switch to minitest
32+
* #123 Base64 encoded dn
33+
* #114 Separate file for Net::LDAP::Connection
34+
* #104 Parse version spec in LDIF datasets
35+
* #106 ldap.modify doc fixes
36+
* #111 Fix test deprecations
37+
138
=== Net::LDAP 0.5.0 / 2013-07-22
239
* Major changes:
340
* Required Ruby version is >=1.9.3

Manifest.txt

Lines changed: 0 additions & 55 deletions
This file was deleted.

README.rdoc

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
= Net::LDAP for Ruby {<img src="https://travis-ci.org/ruby-ldap/ruby-net-ldap.png" />}[https://travis-ci.org/ruby-ldap/ruby-net-ldap]
1+
= Net::LDAP for Ruby {<img src="https://travis-ci.org/github/ruby-net-ldap.png" />}[https://travis-ci.org/github/ruby-net-ldap]
22

33
== Description
44

@@ -16,13 +16,8 @@ the most recent LDAP RFCs (4510–4519, plus portions of 4520–4532).
1616

1717
== Where
1818

19-
* {RubyForge}[http://rubyforge.org/projects/net-ldap]
2019
* {GitHub}[https://github.com/ruby-ldap/ruby-net-ldap]
2120
* {[email protected]}[http://groups.google.com/group/ruby-ldap]
22-
* {Documentation}[http://net-ldap.rubyforge.org/]
23-
24-
The Net::LDAP for Ruby documentation, project description, and main downloads
25-
can currently be found on {RubyForge}[http://rubyforge.org/projects/net-ldap].
2621

2722
== Synopsis
2823

@@ -42,6 +37,14 @@ sources.
4237

4338
Simply require either 'net-ldap' or 'net/ldap'.
4439

40+
== Release
41+
42+
This section is for gem maintainers to cut a new version of the gem.
43+
44+
* Update lib/html/pipeline/version.rb to next version number X.X.X following {semver}(http://semver.org/).
45+
* Update CHANGELOG.md. Get latest changes with `git log --oneline vLAST_RELEASE..HEAD | grep Merge`
46+
* On the master branch, run `script/release`
47+
4548
:include: Contributors.rdoc
4649

4750
:include: License.rdoc

Rakefile

Lines changed: 8 additions & 71 deletions
Original file line numberDiff line numberDiff line change
@@ -1,76 +1,13 @@
1+
#!/usr/bin/env rake
12
# -*- ruby encoding: utf-8 -*-
3+
# vim: syntax=ruby
24

3-
require "rubygems"
4-
require 'hoe'
5-
6-
Hoe.plugin :doofus
7-
Hoe.plugin :git
8-
Hoe.plugin :gemspec
9-
10-
Hoe.spec 'net-ldap' do |spec|
11-
# spec.rubyforge_name = spec.name
12-
13-
spec.developer("Francis Cianfrocca", "[email protected]")
14-
spec.developer("Emiel van de Laar", "[email protected]")
15-
spec.developer("Rory O'Connell", "[email protected]")
16-
spec.developer("Kaspar Schiess", "[email protected]")
17-
spec.developer("Austin Ziegler", "[email protected]")
18-
spec.developer("Michael Schaarschmidt", "[email protected]")
19-
20-
spec.remote_rdoc_dir = ''
21-
spec.rsync_args << ' --exclude=statsvn/'
22-
23-
spec.urls = %w(http://rubyldap.com/' 'https://github.com/ruby-ldap/ruby-net-ldap)
24-
spec.licenses = ['MIT']
25-
26-
spec.history_file = 'History.rdoc'
27-
spec.readme_file = 'README.rdoc'
28-
29-
spec.extra_rdoc_files = FileList["*.rdoc"].to_a
30-
31-
spec.extra_dev_deps << [ "hoe-git", "~> 1" ]
32-
spec.extra_dev_deps << [ "hoe-gemspec", "~> 1" ]
33-
spec.extra_dev_deps << [ "metaid", "~> 1" ]
34-
spec.extra_dev_deps << [ "flexmock", ">= 1.3.0" ]
35-
spec.extra_dev_deps << [ "rspec", "~> 2.0" ]
36-
37-
spec.clean_globs << "coverage"
38-
39-
spec.spec_extras[:required_ruby_version] = ">= 1.8.7"
40-
spec.multiruby_skip << "1.8.6"
41-
spec.multiruby_skip << "1_8_6"
42-
43-
spec.need_tar = true
44-
end
45-
46-
# I'm not quite ready to get rid of this, but I think "rake git:manifest" is
47-
# sufficient.
48-
namespace :old do
49-
desc "Build the manifest file from the current set of files."
50-
task :build_manifest do |t|
51-
require 'find'
52-
53-
paths = []
54-
Find.find(".") do |path|
55-
next if File.directory?(path)
56-
next if path =~ /\.svn/
57-
next if path =~ /\.git/
58-
next if path =~ /\.hoerc/
59-
next if path =~ /\.swp$/
60-
next if path =~ %r{coverage/}
61-
next if path =~ /~$/
62-
paths << path.sub(%r{^\./}, '')
63-
end
64-
65-
File.open("Manifest.txt", "w") do |f|
66-
f.puts paths.sort.join("\n")
67-
end
5+
require 'rake/testtask'
686

69-
puts paths.sort.join("\n")
70-
end
7+
Rake::TestTask.new do |t|
8+
t.libs << "test"
9+
t.test_files = FileList['test/**/test_*.rb']
10+
t.verbose = true
7111
end
7212

73-
desc "Run a full set of integration and unit tests"
74-
task :cruise => [:test, :spec]
75-
76-
# vim: syntax=ruby
13+
task :default => :test

0 commit comments

Comments
 (0)