remove useless copying and a fix

Author: janbiedermann

lib/react/component/should_component_update.rb

@@ -23,14 +23,13 @@ module Component
     # the need for needs_update?
     #
     module ShouldComponentUpdate
-      def should_component_update?(native_next_props, native_next_state)
+      def should_component_update?(next_params, next_state)
         State.set_state_context_to(self, false) do
-          next_params = native_next_props.clone
           # rubocop:disable Style/DoubleNegation # we must return true/false to js land
           if respond_to?(:needs_update?)
-            !!call_needs_update(next_params, native_next_state)
+            !!call_needs_update(next_params, next_state)
           else
-            !!(props_changed?(next_params) || native_state_changed?(native_next_state))
+            !!(props_changed?(next_params) || native_state_changed?(next_state))
           end
           # rubocop:enable Style/DoubleNegation
         end
@@ -39,14 +38,13 @@ def should_component_update?(native_next_props, native_next_state)
       # create opal hashes for next params and state, and attach
       # the changed? method to each hash
 
-      def call_needs_update(next_params, native_next_state)
+      def call_needs_update(next_params, next_state)
         component = self
         next_params.define_singleton_method(:changed?) do
           component.props_changed?(self)
         end
-        next_state = Hash.new(native_next_state)
         next_state.define_singleton_method(:changed?) do
-          component.native_state_changed?(native_next_state)
+          component.native_state_changed?(next_state)
         end
         needs_update?(next_params, next_state)
       end
@@ -64,7 +62,7 @@ def call_needs_update(next_params, native_next_state)
       # Otherwise we check time stamps
 
       # rubocop:disable Metrics/MethodLength # for effeciency we want this to be one method
-      def native_state_changed?(next_state)
+      def native_state_changed?(next_state_hash)
         next_state = next_state_hash.to_n
         %x{
           var current_state = #{@native}.state