Fix #162

Author: zetachang

CHANGELOG.md

@@ -18,7 +18,13 @@ Whitespace conventions:
 - 1 spaces before normal text
  -->
 
-## [0.9.0]
+## [0.9.1] - Unreleased
+
+### Fixed
+
+- ReactJS functional stateless component could not be imported from `NativeLibrary`. Note that functional component is only supported in React v14+.  (#162)
+
+## [0.9.0] - 2016-10-19
 
 ### Added
 

lib/react/api.rb

@@ -23,8 +23,12 @@ def self.import_native_component(opal_class, native_class)
     def self.eval_native_react_component(name)
       component = `eval(name)`
       raise "#{name} is not defined" if `#{component} === undefined`
-      unless `#{component}.prototype !== undefined` &&
-             (`!!#{component}.prototype.isReactComponent` || `!!#{component}.prototype.render`)
+      is_component_class = `#{component}.prototype !== undefined` &&
+                            (`!!#{component}.prototype.isReactComponent` ||
+                             `!!#{component}.prototype.render`)
+      is_functional_component = `typeof #{component} === "function"`
+      is_not_using_react_v13 = `!window.React.version.match(/0\.13/)`
+      unless is_component_class || (is_not_using_react_v13 && is_functional_component)
         raise 'does not appear to be a native react component'
       end
       component

spec/react/native_library_spec.rb

@@ -31,6 +31,32 @@ class NestedComponent < React::Component::Base
     Object.send :remove_const, :NativeComponent
   end
 
+  describe "functional stateless component (supported in reactjs v14+ only)" do
+    it "is not detected as native React.js component by `native_react_component?`", v13_only: true do
+      expect(React::API.native_react_component?(`function C(){ return null }`)).to be_falsy
+    end
+
+    it "is detected as native React.js component by `native_react_component?`", v13_exclude: true do
+      expect(React::API.native_react_component?(`function C(){ return null }`)).to be_truthy
+    end
+
+    it "imports a React.js functional stateless component", v13_exclude: true do
+      %x{
+        window.NativeLibrary = {
+          FunctionalComponent: function HelloMessage(props){
+            return React.createElement("div", null, "Hello ", props.name);
+          }
+        }
+      }
+      stub_const 'Foo', Class.new(React::Component::Base)
+      Foo.class_eval do
+        imports "NativeLibrary.FunctionalComponent"
+      end
+      expect(React.render_to_static_markup(
+        React.create_element(Foo, name: "There"))).to eq('<div>Hello There</div>')
+    end
+  end
+
   it "can use native_react_component? to detect a native React.js component" do
     %x{
       window.NativeComponent = React.createClass({

spec/spec_helper.rb

@@ -74,6 +74,8 @@ def self.should_immediately_generate(opts={}, &block)
     config.filter_run_excluding :ruby
     if `(React.version.search(/^0\.13/) === -1)`
       config.filter_run_excluding :v13_only
+    else
+      config.filter_run_excluding :v13_exclude
     end
   end
 end