This repository was archived by the owner on Oct 19, 2018. It is now read-only.
File tree Expand file tree Collapse file tree 3 files changed +9
-2
lines changed Expand file tree Collapse file tree 3 files changed +9
-2
lines changed Original file line number Diff line number Diff line change @@ -26,6 +26,7 @@ Whitespace conventions:
26
26
27
27
### Fixed
28
28
29
+ - ` $window#on ` in ` opal-jquery ` is broken. (#166 )
29
30
- ` Element#render ` trigger unnecessary re-mounts when called multiple times. (#170 )
30
31
- Gets rid of react warnings about updating state during render (#155 )
31
32
- Multiple HAML classes (i.e. div.foo.bar) was not working (regression introduced in 0.8.8)
Original file line number Diff line number Diff line change @@ -110,7 +110,7 @@ def self.find(selector)
110
110
selector . dom_node
111
111
rescue
112
112
selector
113
- end if selector . respond_to? : dom_node
113
+ end if ` #{ selector } .$ dom_node !== undefined`
114
114
`$(#{ selector } )`
115
115
end
116
116
@@ -126,7 +126,7 @@ def self.[](selector)
126
126
klass . class_eval do
127
127
render ( container , params , &block )
128
128
end
129
-
129
+
130
130
React . render ( React . create_element ( `#{ self . to_n } ._reactrb_component_class` ) , self )
131
131
end
132
132
end if Object . const_defined? ( 'Element' )
Original file line number Diff line number Diff line change @@ -56,5 +56,11 @@ def render
56
56
57
57
expect ( Element [ renderToDocument ( Foo ) ] . html ) . to eq ( 'hello' )
58
58
end
59
+
60
+ it "accepts plain js object as selector" do
61
+ expect {
62
+ Element [ `window` ]
63
+ } . not_to raise_error
64
+ end
59
65
end
60
66
end
You can’t perform that action at this time.
0 commit comments