Readress #158

Author: zetachang

lib/react/api.rb

@@ -104,15 +104,14 @@ def self.create_element(type, properties = {}, &block)
         params << create_native_react_class(type)
       elsif React::Component::Tags::HTML_TAGS.include?(type)
         params << type
-        html_tag = true
       elsif type.is_a? String
         return React::Element.new(type)
       else
         raise "#{type} not implemented"
       end
 
       # Convert Passed in properties
-      properties = convert_props(properties, html_tag)
+      properties = convert_props(properties)
       params << properties.shallow_to_n
 
       # Children Nodes
@@ -128,18 +127,14 @@ def self.clear_component_class_cache
       @@component_classes = {}
     end
 
-    def self.convert_props(properties, html_tag)
+    def self.convert_props(properties)
       raise "Component parameters must be a hash. Instead you sent #{properties}" unless properties.is_a? Hash
       props = {}
-      updated = false
       properties.map do |key, value|
         if key == "class_name" && value.is_a?(Hash)
           props[lower_camelize(key)] = `React.addons.classSet(#{value.to_n})`
         elsif key == "class"
           props["className"] = value
-        elsif key == 'value' && value.nil? && html_tag
-          updated = true
-          props['value'] = ''
         elsif ["style", "dangerously_set_inner_HTML"].include? key
           props[lower_camelize(key)] = value.to_n
         elsif React::HASH_ATTRIBUTES.include?(key) && value.is_a?(Hash)

lib/react/element.rb

@@ -36,7 +36,7 @@ def initialize(native_element, type, properties, block)
 
     def on(*event_names, &block)
       event_names.each { |event_name| merge_event_prop!(event_name, &block) }
-      @native = `React.cloneElement(#{to_n}, #{properties.to_n})`
+      @native = `React.cloneElement(#{to_n}, #{properties.shallow_to_n})`
       self
     end
 

spec/react/dsl_spec.rb

@@ -56,19 +56,6 @@ def render
     expect(React.render_to_static_markup(React.create_element(Foo))).to eq('<div>hello</div>')
   end
 
-  it "will pass the empty string for the value attribute" do
-    stub_const 'Foo', Class.new
-    Foo.class_eval do
-      include React::Component
-      def render
-        INPUT(value: nil).on(:change) {}
-      end
-    end
-
-    expect(React.render_to_static_markup(React.create_element(Foo))).to eq('<input value=""/>')
-  end
-
-
   it "will pass converted props through event handlers" do
     stub_const 'Foo', Class.new
     Foo.class_eval do

spec/react/element_spec.rb

@@ -19,6 +19,20 @@
     end
   end
 
+  describe "Event Subscription" do
+    it "keeps the original params" do
+      stub_const 'Foo', Class.new
+      Foo.class_eval do
+        include React::Component
+        def render
+          INPUT(value: nil, type: 'text').on(:change) {}
+        end
+      end
+
+      expect(React.render_to_static_markup(React.create_element(Foo))).to eq('<input type="text" value=""/>')
+    end
+  end
+
   describe 'Component Event Subscription' do
 
     it 'will subscribe to a component event param' do