closes #17

Author: catmando

lib/hyper-operation/server_op.rb

@@ -46,16 +46,16 @@ def descendants_map_cache
         # calling descendants alone may take 10ms in a complex app, so better cache it
         @cached_descendants ||= Hyperloop::ServerOp.descendants.map(&:to_s)
       end
-    
+
       def run_from_client(security_param, controller, operation, params)
         if Rails.env.production?
           # in production everything is eager loaded so ServerOp.descendants is filled and can be used to guard the .constantize
           Hyperloop::InternalPolicy.raise_operation_access_violation unless Hyperloop::ServerOp.descendants_map_cache.include?(operation)
-          # however ... 
+          # however ...
         else
           # ... in development things are autoloaded on demand, thus ServerOp.descendants can be empty or partially filled and above guard
           # would fail legal operations. To prevent this, the class has to be loaded first, what .const_get will take care of, and then
-          # its guarded, to achieve similar behaviour as in production. Doing the const_get first, before the guard, 
+          # its guarded, to achieve similar behaviour as in production. Doing the const_get first, before the guard,
           # would not be safe for production and allow for potential remote code execution!
           begin
             const = Object.const_get(operation)
@@ -70,7 +70,7 @@ def run_from_client(security_param, controller, operation, params)
           elsif !_Railway.params_wrapper.method_defined?(security_param)
             raise AccessViolation
           end
-          run(params)
+          run(deserialize_params(params))
           .then { |r| return { json: { response: serialize_response(r) } } }
           .fail do |e|
             ::Rails.logger.debug "\033[0;31;1mERROR: Hyperloop::ServerOp failed when running #{operation} with params \"#{params}\": #{e}\033[0;30;21m"

spec/hyper-operation/server_op_spec.rb

@@ -1,6 +1,36 @@
 require 'spec_helper'
 
 describe "isomorphic operations", js: true do
+
+  before(:each) do
+    on_client do
+      class Test < React::Component::Base
+        def self.receive_count
+          @@rc ||= 0
+          @@rc
+        end
+        def self.rc_inc
+          @@rc ||= 0
+          @@rc += 1
+        end
+        before_mount do
+          Operation.on_dispatch do |params|
+            self.class.rc_inc
+            # password is for testing inbound param filtering
+            state.message! "#{params.message}#{params.try(:password)}"
+          end
+        end
+        render do
+          if state.message
+            "The server says '#{state.message}'!"
+          else
+            "No messages yet"
+          end
+        end
+      end
+    end
+  end
+
   context 'uplinking' do
     before(:each) do
       stub_const "ServerFacts", Class.new(Hyperloop::ServerOp)
@@ -75,32 +105,6 @@ class ServerFacts < Hyperloop::ServerOp
 
     before(:each) do
       stub_const "Operation", Class.new(Hyperloop::ServerOp)
-      on_client do
-        class Test < React::Component::Base
-          def self.receive_count
-            @@rc ||= 0
-            @@rc
-          end
-          def self.rc_inc
-            @@rc ||= 0
-            @@rc += 1
-          end
-          before_mount do
-            Operation.on_dispatch do |params|
-              self.class.rc_inc
-              # password is for testing inbound param filtering
-              state.message! "#{params.message}#{params.try(:password)}"
-            end
-          end
-          render do
-            if state.message
-              "The server says '#{state.message}'!"
-            else
-              "No messages yet"
-            end
-          end
-        end
-      end
     end
 
     it 'will dispatch to the client' do
@@ -222,4 +226,64 @@ class Operation < Hyperloop::ServerOp
       expect_evaluate_ruby('Test.receive_count').to eq(2)
     end
   end
+
+  context "serialization overrides" do
+
+    before(:all) do
+      require 'pusher'
+      require 'pusher-fake'
+      Pusher.app_id = "MY_TEST_ID"
+      Pusher.key =    "MY_TEST_KEY"
+      Pusher.secret = "MY_TEST_SECRET"
+      require "pusher-fake/support/base"
+
+      Hyperloop.configuration do |config|
+        config.transport = :pusher
+        config.channel_prefix = "synchromesh"
+        config.opts = {app_id: Pusher.app_id, key: Pusher.key, secret: Pusher.secret}.merge(PusherFake.configuration.web_options)
+      end
+    end
+
+    it 'calls the subclasses serializer and deserializer methods' do
+      isomorphic do
+        class Operation < Hyperloop::ServerOp
+          param :acting_user, nils: true
+          param :counter
+          outbound :message
+          step {params.message = 'hello'}
+          step {params.counter + 1}
+          def self.serialize_params(hash)
+            hash['counter'] += 1
+            hash
+          end
+          def self.deserialize_params(hash)
+            hash['counter'] += 1
+            hash
+          end
+          def self.serialize_response(response)
+            response + 1
+          end
+          def self.deserialize_response(response)
+            response + 1
+          end
+          def self.serialize_dispatch(hash)
+            hash[:message] += ' serialized'
+            hash
+          end
+          def self.deserialize_dispatch(hash)
+            hash[:message] += ' deserialized'
+            hash
+          end
+        end
+      end
+      stub_const "OperationPolicy", Class.new
+      OperationPolicy.always_allow_connection
+      mount 'Test'
+
+      expect_promise do
+        Operation.run(counter: 1)
+      end.to eq(6)
+      expect(page).to have_content("The server says 'hello serialized deserialized'!")
+    end
+  end
 end