New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review usages of Integer#size in the gem #1057

Open

eregon opened this issue Jul 25, 2024 · 1 comment

Collaborator

eregon commented Jul 25, 2024

From @XrXr in https://bugs.ruby-lang.org/issues/20614#note-8, we should review usages of Integer#size as it is not equal to pointer size on Windows.

Collaborator Author

eregon commented Jul 25, 2024

https://github.com/search?q=repo%3Aruby-concurrency%2Fconcurrent-ruby%200.size&type=code

concurrent-ruby/lib/concurrent-ruby/concurrent/thread_safe/util.rb

Line 10 in cadc8de

FIXNUM_BIT_SIZE = (0.size * 8) - 2

concurrent-ruby/lib/concurrent-ruby/concurrent/utility/native_integer.rb

Lines 7 to 8 in cadc8de

    
           MIN_VALUE = -(2**(0.size * 8 - 2)) 
        
           MAX_VALUE = (2**(0.size * 8 - 2) - 1)

concurrent-ruby/lib/concurrent-ruby/concurrent/thread_safe/util/xor_shift_random.rb

Line 32 in cadc8de

if 0.size == 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment