#swap also has 'volatile' semantics

alexdowad · alexdowad · commit a762883cfac9 · 2014-08-09T14:18:29.000+02:00
diff --git a/ext/atomic_reference.c b/ext/atomic_reference.c
@@ -60,9 +60,8 @@ static VALUE ir_set(VALUE self, VALUE new_value) {
 }
 
 static VALUE ir_get_and_set(VALUE self, VALUE new_value) {
-    VALUE old_value;
-    old_value = (VALUE) DATA_PTR(self);
-    DATA_PTR(self) = (void *) new_value;
+    VALUE old_value = ir_get(self);
+    ir_set(self, new_value);
     return old_value;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -60,9 +60,8 @@ static VALUE ir_set(VALUE self, VALUE new_value) {`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`static VALUE ir_get_and_set(VALUE self, VALUE new_value) {`
`63`		`- VALUE old_value;`
`64`		`- old_value = (VALUE) DATA_PTR(self);`
`65`		`- DATA_PTR(self) = (void *) new_value;`
	`63`	`+ VALUE old_value = ir_get(self);`
	`64`	`+ ir_set(self, new_value);`
`66`	`65`	`return old_value;`
`67`	`66`	`}`
`68`	`67`