-
Notifications
You must be signed in to change notification settings - Fork 153
Issue with > character on IE #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I have the exact same issue with a different character and found out that IE converts the loaded JSON file. And changes & to & so > will probably become > The translation is then not found. |
That fixes it for me. |
I was hitting this issue while using the translate filter:
If I switch to using the translate directive it will work on IE... but break on Chrome and Firefox:
|
OK. I just investigated this a bit further and the issue is not caused by IE / Edge converting the loaded JSON (that doesn't actually happen). The issue is that This was added to account for IE uppercasing tag names and re-ordering HTML attributes. That being said, your proposed fix is the best solution for what appears to be a pretty severe issue... |
Yes, see my pull-request, which determines exactly the same, and notices that the fix isn't applied at a second location. |
Fixes rubenv#301 See: rubenv#312 Note: this commit / fork is just a temporary hold over to npm install from until this is officially fixed upstream.
Fixes rubenv#301 See: rubenv#312 Note: this commit / fork is just a temporary hold over to npm install from until this is officially fixed upstream.
Hello, Thanks |
Hello I am also interested pulling request #312. The suggested fix helped me. Thanks |
Hi, #312 works for me too, It seems pull request is open for a while, Do you have a plan to merge it or Do you have another solution? Thanks |
Hi rubenv,
When I use a string that contains ">" on it, I get no translation on IE. Example:
scope.sentence = gettextCatalog.getString('Sentence with > on it')
<span ng-bind="sentence"></span>
On Chrome/Firefox, it works perfectly.
Thanks for your patience.
The text was updated successfully, but these errors were encountered: