Skip to content
This repository was archived by the owner on Nov 23, 2024. It is now read-only.

Commit 908804c

Browse files
committed
set error to null instead of undefined to enable SSR with Next.js (getServerSideProps)
1 parent 206bd44 commit 908804c

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

src/core/buildSlice.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ export function buildSlice({
9898
if (substate.requestId !== meta.requestId) return;
9999
substate.status = QueryStatus.fulfilled;
100100
substate.data = copyWithStructuralSharing(substate.data, payload.result);
101-
substate.error = undefined;
101+
substate.error = null;
102102
substate.fulfilledTimeStamp = payload.fulfilledTimeStamp;
103103
});
104104
})

test/buildHooks.test.tsx

+6-1
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ describe('hooks tests', () => {
423423
expect(api.endpoints.getUser.select(USER_ID)(storeRef.store.getState())).toEqual({
424424
data: undefined,
425425
endpoint: 'getUser',
426-
error: undefined,
426+
error: null,
427427
fulfilledTimeStamp: expect.any(Number),
428428
internalQueryArgs: USER_ID,
429429
isError: false,
@@ -441,6 +441,7 @@ describe('hooks tests', () => {
441441
expect(api.endpoints.getUser.select(USER_ID)(storeRef.store.getState())).toEqual({
442442
data: undefined,
443443
endpoint: 'getUser',
444+
error: null,
444445
fulfilledTimeStamp: expect.any(Number),
445446
internalQueryArgs: USER_ID,
446447
isError: false,
@@ -483,6 +484,7 @@ describe('hooks tests', () => {
483484
expect(api.endpoints.getUser.select(USER_ID)(storeRef.store.getState())).toEqual({
484485
data: undefined,
485486
endpoint: 'getUser',
487+
error: null,
486488
fulfilledTimeStamp: expect.any(Number),
487489
internalQueryArgs: USER_ID,
488490
isError: false,
@@ -500,6 +502,7 @@ describe('hooks tests', () => {
500502
expect(api.endpoints.getUser.select(USER_ID)(storeRef.store.getState())).toEqual({
501503
data: undefined,
502504
endpoint: 'getUser',
505+
error: null,
503506
fulfilledTimeStamp: expect.any(Number),
504507
internalQueryArgs: USER_ID,
505508
isError: false,
@@ -544,6 +547,7 @@ describe('hooks tests', () => {
544547
expect(api.endpoints.getUser.select(USER_ID)(storeRef.store.getState())).toEqual({
545548
data: undefined,
546549
endpoint: 'getUser',
550+
error: null,
547551
fulfilledTimeStamp: expect.any(Number),
548552
internalQueryArgs: USER_ID,
549553
isError: false,
@@ -561,6 +565,7 @@ describe('hooks tests', () => {
561565
expect(api.endpoints.getUser.select(USER_ID)(storeRef.store.getState())).toEqual({
562566
data: undefined,
563567
endpoint: 'getUser',
568+
error: null,
564569
fulfilledTimeStamp: expect.any(Number),
565570
internalQueryArgs: USER_ID,
566571
isError: false,

test/buildThunks.test.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ test('handles a non-async baseQuery without error', async () => {
4040
internalQueryArgs: {
4141
url: 'user/1',
4242
},
43+
error: null,
4344
isError: false,
4445
isLoading: false,
4546
isSuccess: true,

test/errorHandling.test.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ describe('query error handling', () => {
148148
isError: false,
149149
isSuccess: true,
150150
data: { value: 'success' },
151-
error: undefined,
151+
error: null,
152152
})
153153
);
154154
});

0 commit comments

Comments
 (0)