Replace glob by tinyglobby (#647)

Co-authored-by: Simon Lydell <[email protected]>

Author: jfmengels

.github/workflows/test.yml

@@ -50,10 +50,6 @@ jobs:
         env:
           NO_ELM_TOOLING_INSTALL: 1
 
-      - name: install glob 8
-        if: steps.cache-node_modules.outputs.cache-hit != 'true' && (matrix.node-version == '12.x' || matrix.node-version == '14.x')
-        run: npm install glob@8
-
       - name: install mocha 9
         if: steps.cache-node_modules.outputs.cache-hit != 'true' && (matrix.node-version == '12.x' || matrix.node-version == '14.x' || matrix.node-version == '16.x')
         run: npm install mocha@9

lib/FindTests.js

@@ -2,7 +2,7 @@
 
 const gracefulFs = require('graceful-fs');
 const fs = require('fs');
-const glob = require('glob');
+const { globSync } = require('tinyglobby');
 const path = require('path');
 const Parser = require('./Parser');
 const Project = require('./Project');
@@ -59,44 +59,39 @@ function resolveCliArgGlob(
     path.resolve(fileGlob)
   );
 
-  // glob@8 (via minimatch@5) had a breaking change where you _have_ to use
-  // forwards slash as path separator, regardless of platform, making it
-  // unambiguous which characters are separators and which are escapes. This
-  // restores the previous behavior, avoiding a breaking change in elm-test.
+  // The globs _have_ to use forwards slash as path separator, regardless of
+  // platform, making it unambiguous which characters are separators and which
+  // are escapes.
   // Note: As far I can tell, escaping glob syntax has _never_ worked on
   // Windows. In Elm, needing to escape glob syntax should be very rare, since
   // Elm file paths must match the module name (letters only). So it’s probably
   // more worth supporting `some\folder\*Test.elm` rather than escaping.
-  // https://github.com/isaacs/node-glob/issues/468
-  // https://github.com/isaacs/minimatch/commit/9104d8d175bdd8843338103be1401f80774d2a10#diff-f41746899d033115e03bebe4fbde76acf2de4bf261bfb221744808f4c8a286cf
   const pattern =
     process.platform === 'win32'
       ? globRelativeToProjectRoot.replace(/\\/g, '/')
       : globRelativeToProjectRoot;
 
-  return glob
-    .sync(pattern, {
-      cwd: projectRootDir,
-      nocase: true,
-      absolute: true,
-      ignore: ignoredDirsGlobs,
-      // Match directories as well and mark them with a trailing slash.
-      nodir: false,
-      mark: true,
-    })
-    .flatMap((filePath) =>
-      filePath.endsWith('/') ? findAllElmFilesInDir(filePath) : filePath
-    );
+  return globSync(pattern, {
+    cwd: projectRootDir,
+    caseSensitiveMatch: false,
+    absolute: true,
+    ignore: ignoredDirsGlobs,
+    // Match directories as well
+    onlyFiles: false,
+  }).flatMap((filePath) =>
+    // Directories have their path end with `/`
+    filePath.endsWith('/') ? findAllElmFilesInDir(filePath) : filePath
+  );
 }
 
 // Recursively search for *.elm files.
 function findAllElmFilesInDir(dir /*: string */) /*: Array<string> */ {
-  return glob.sync('**/*.elm', {
+  return globSync('**/*.elm', {
     cwd: dir,
-    nocase: true,
+    caseSensitiveMatch: false,
     absolute: true,
     ignore: ignoredDirsGlobs,
-    nodir: true,
+    onlyFiles: true,
   });
 }