From 53809f14aaa4924da2df6ef7b3bd60ee7543bf1e Mon Sep 17 00:00:00 2001 From: cching95 <73163191+cching95@users.noreply.github.com> Date: Thu, 27 Jul 2023 14:26:05 +0100 Subject: [PATCH] fix meta data tag name error and update unit test (#401) Signed-off-by: cching95 <73163191+cching95@users.noreply.github.com> --- src/sdk/python/rtdip_sdk/queries/time_series/_query_builder.py | 2 +- tests/sdk/python/rtdip_sdk/queries/test_metadata.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sdk/python/rtdip_sdk/queries/time_series/_query_builder.py b/src/sdk/python/rtdip_sdk/queries/time_series/_query_builder.py index 30a45eb0d..085e94bed 100644 --- a/src/sdk/python/rtdip_sdk/queries/time_series/_query_builder.py +++ b/src/sdk/python/rtdip_sdk/queries/time_series/_query_builder.py @@ -204,7 +204,7 @@ def _metadata_query(parameters_dict: dict) -> str: "SELECT * FROM " "`{{ business_unit }}`.`sensors`.`{{ asset }}_{{ data_security_level }}_metadata` " "{% if tag_names is defined and tag_names|length > 0 %} " - "WHERE TagName in ({{ tag_names | join('\\', \\'') }}) " + "WHERE TagName in ('{{ tag_names | join('\\', \\'') }}') " "{% endif %}" ) diff --git a/tests/sdk/python/rtdip_sdk/queries/test_metadata.py b/tests/sdk/python/rtdip_sdk/queries/test_metadata.py index 4311670c1..be521ea86 100644 --- a/tests/sdk/python/rtdip_sdk/queries/test_metadata.py +++ b/tests/sdk/python/rtdip_sdk/queries/test_metadata.py @@ -28,7 +28,7 @@ DATABRICKS_SQL_CONNECT = 'databricks.sql.connect' DATABRICKS_SQL_CONNECT_CURSOR = 'databricks.sql.connect.cursor' INTERPOLATION_METHOD = "test/test/test" -MOCKED_QUERY='SELECT * FROM `mocked-buiness-unit`.`sensors`.`mocked-asset_mocked-data-security-level_metadata` WHERE TagName in (MOCKED-TAGNAME) ' +MOCKED_QUERY="SELECT * FROM `mocked-buiness-unit`.`sensors`.`mocked-asset_mocked-data-security-level_metadata` WHERE TagName in ('MOCKED-TAGNAME') " MOCKED_PARAMETER_DICT = { "business_unit": "mocked-buiness-unit", "region": "mocked-region",