Remove explicit sprockets dependency for Rails 7 #2530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[!] There was an error parsing `Gemfile`:
[!] There was an error parsing `Gemfile-rails-dependencies`: You cannot specify the same gem twice with different version requirements.
You specified: sprockets-rails (>= 2.0.0) and sprockets-rails (>= 0). Bundler cannot continue.
# from /home/runner/work/rspec-rails/rspec-rails/Gemfile-rails-dependencies:10
# -------------------------------------------
# gem 'sprockets', :git => 'https://github.com/rails/sprockets.git', :branch => 'master'
> gem 'sprockets-rails', :git => 'https://github.com/rails/sprockets-rails.git', :branch => 'master'
pirj
commented
Nov 16, 2021
Comment on lines
-6
to
-8
| gem "activerecord-deprecated_finders", :git => "https://github.com/rails/activerecord-deprecated_finders.git" | ||
| gem "web-console", :git => "https://github.com/rails/web-console", :group => :development | ||
| gem 'coffee-rails', :git => "https://github.com/rails/coffee-rails.git" |
|
Rails 7 build is not entirely green, but at least it runs. #2521 is supposed to fix some of the failures. |
|
@pirj I don't have time to debug Rails 7 / master stuff right now, merge this if you're happy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/rspec/rspec-rails/runs/4222116982?check_suite_focus=true