Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit bce49d8

Browse files
committedDec 30, 2021
Stop using the deceiving continue-on-error
Build jobs appear as green even though they actually fail. A better approach is to mark jobs as "required" in branch protection. This way failed jobs are red, but this doesn't prevent the PR from being merged upon at maintainers' discretion.
1 parent 48b007f commit bce49d8

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed
 

‎.github/workflows/ci.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,25 +18,20 @@ jobs:
1818
include:
1919
# Edge Rails (7.1) builds >= 2.7
2020
- ruby: '3.0'
21-
allow_failure: true
2221
env:
2322
RAILS_VERSION: 'main'
2423
- ruby: 2.7
25-
allow_failure: true
2624
env:
2725
RAILS_VERSION: 'main'
2826

2927
# Rails 7.0 builds >= 2.7
3028
- ruby: 3.1
31-
allow_failure: true
3229
env:
3330
RAILS_VERSION: '~> 7.0.0'
3431
- ruby: '3.0'
35-
allow_failure: true
3632
env:
3733
RAILS_VERSION: '~> 7.0.0'
3834
- ruby: 2.7
39-
allow_failure: true
4035
env:
4136
RAILS_VERSION: '~> 7.0.0'
4237

@@ -113,4 +108,4 @@ jobs:
113108
- run: script/clone_all_rspec_repos
114109
- run: bundle install --binstubs
115110
- run: script/run_build
116-
continue-on-error: ${{ matrix.allow_failure || false }}
111+
continue-on-error: false

0 commit comments

Comments
 (0)
Please sign in to comment.