fixes invalid url crash (#69)

Author: ayush-yadav001

Package.swift

@@ -104,7 +104,17 @@ let package = Package(
         .testTarget(name: "RSocketWSTransportTests", dependencies: [
             "RSocketWSTransport"
         ]),
-        
+        .testTarget(name: "RSocketNIOChannelTests", dependencies: [
+            "RSocketNIOChannel",
+            "RSocketWSTransport",
+            "RSocketTestUtilities"
+        ]),
+        .testTarget(name: "RSocketTSChannelTests", dependencies: [
+            "RSocketTSChannel",
+            "RSocketWSTransport",
+            "RSocketTestUtilities",
+            "RSocketCore"
+        ]),
         // Examples
         .executableTarget(
             name: "TimerClientExample",

Sources/RSocketNIOChannel/ClientBootstrap.swift

@@ -88,6 +88,7 @@ extension ClientBootstrap: RSocketCore.ClientBootstrap {
                 }
             }
             .connect(host: endpoint.host, port: endpoint.port)
+        connectFuture.cascadeFailure(to: requesterPromise)
         return connectFuture.flatMap { channel in
             requesterPromise.futureResult.map { socket in
                 // initializing core client using channel object

Sources/RSocketTSChannel/ClientBootstrap.swift

@@ -82,6 +82,7 @@ extension ClientBootstrap: RSocketCore.ClientBootstrap {
                 }
             }
             .connect(host: endpoint.host, port: endpoint.port)
+        connectFuture.cascadeFailure(to: requesterPromise)
         return connectFuture.flatMap { channel in
             requesterPromise.futureResult.map { socket in
                 // initializing core client using channel object

Tests/RSocketNIOChannelTests/RSocketNIOChannelTests.swift

@@ -0,0 +1,46 @@
+/*
+ * Copyright 2015-present the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import XCTest
+@testable import RSocketNIOChannel
+import RSocketWSTransport
+import RSocketTestUtilities
+import RSocketCore
+class RSocketNIOChannelTests: XCTestCase {
+    var clientBootStrap: RSocketNIOChannel.ClientBootstrap<WSTransport>?
+    override func setUp() {
+        clientBootStrap = ClientBootstrap(
+            transport: WSTransport(),
+            config: .mobileToServer
+                .set(\.encoding.metadata, to: .messageXRSocketRoutingV0)
+                .set(\.encoding.data, to: .applicationJson)
+        )
+    }
+    /// test case for invalid url
+    func testInvalidUrlErrorCatch() {
+        let invalidUrlErrorCatch = expectation(description: "invalid url error catch")
+        let headerDict: [String: String] = ["": ""]
+        let uri = URL(string: "http://127.0.0.1/V1/Mock")!
+        // creating connection with invalid url
+        let bootstrap = clientBootStrap?.connect(to: WSTransport.Endpoint(url: uri, additionalHTTPHeader: headerDict),
+                                                 payload: Payload(metadata: "", data: ""), responder: TestRSocket())
+        // catch error on future fails
+        bootstrap?.whenFailure({ _ in
+            invalidUrlErrorCatch.fulfill()
+        })
+        self.wait(for: [invalidUrlErrorCatch], timeout: 0.1)
+    }
+}

Tests/RSocketTSChannelTests/RSocketTSChannelTests.swift

@@ -0,0 +1,56 @@
+/*
+ * Copyright 2015-present the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#if canImport(Network)
+
+import XCTest
+@testable import RSocketTSChannel
+import RSocketTestUtilities
+import RSocketCore
+import RSocketWSTransport
+import NIOTransportServices
+
+@available(OSX 10.14, iOS 12.0, tvOS 12.0, watchOS 6.0, *)
+class RSocketTSChannelTests: XCTestCase {
+    var clientBootStrap: RSocketTSChannel.ClientBootstrap<WSTransport>?
+    override func setUp() {
+        clientBootStrap = ClientBootstrap(
+            transport: WSTransport(),
+            config: .mobileToServer
+                .set(\.encoding.metadata, to: .messageXRSocketRoutingV0)
+                .set(\.encoding.data, to: .applicationJson)
+        )
+    }
+    /// test case for invalid url
+    func testInvalidUrlErrorCatch() {
+        let invalidUrlErrorCatch = expectation(description: "invalid url error catch")
+        let headerDict: [String: String] = ["": ""]
+        let uri = URL(string: "http://127.0.0.1/V1/Mock")!
+        clientBootStrap?.configure {
+            $0.channelOption(NIOTSChannelOptions.waitForActivity, value: false)
+        }
+        // creating connection with invalid url
+        let bootstrap = clientBootStrap?.connect(to: WSTransport.Endpoint(url: uri, additionalHTTPHeader: headerDict),
+                                                 payload: Payload(metadata: "", data: ""), responder: TestRSocket())
+        // catch error on future fails
+        bootstrap?.whenFailure({ _ in
+            invalidUrlErrorCatch.fulfill()
+        })
+        self.wait(for: [invalidUrlErrorCatch], timeout: 0.1)
+    }
+
+}
+
+#endif