Skip to content

Commit db67f83

Browse files
fanzeyifacebook-github-bot
authored andcommitted
build zstd in static to avoid DLL dependency on Windows
Summary: It seems after updating zstd to 1.4.5. `Dllexport` for zstd.dll was not being picked up correctly. Instead of having zstd being a runtime dependency let's try statically link it to avoid the DLL issue. Reviewed By: vitaut Differential Revision: D23970349 fbshipit-source-id: 3b14dddb64d410cb9546c416f27d73b7604b21ba
1 parent 853208c commit db67f83

File tree

1 file changed

+3
-0
lines changed
  • build/fbcode_builder/manifests

1 file changed

+3
-0
lines changed

build/fbcode_builder/manifests/zstd

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,6 @@ subdir = zstd-1.4.5/build/cmake
2323
# term solution for this is just to link static on macos.
2424
[cmake.defines.os=darwin]
2525
ZSTD_BUILD_SHARED = OFF
26+
27+
[cmake.defines.os=windows]
28+
ZSTD_BUILD_SHARED = OFF

0 commit comments

Comments
 (0)