Skip to content

Commit d489df2

Browse files
fanzeyifacebook-github-bot
authored andcommitted
GitHub Action: fix Windows build
Summary: Watchman's GitHub Action has been failing because of the use of `set-env` is deprecated due to security issues. See https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ for details. See https://github.com/facebook/watchman/runs/1520165260?check_suite_focus=true for example of failures. To fix it we just need to write to the special environment file. Reviewed By: chadaustin Differential Revision: D25412442 fbshipit-source-id: d31ef025189c8aebfa08d434d9373f5da7d4690e
1 parent 0c9954e commit d489df2

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

build/fbcode_builder/getdeps.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -826,10 +826,10 @@ def write_job_for_platform(self, platform, args): # noqa: C901
826826
# coupled with the boost manifest
827827
# This is the unusual syntax for setting an env var for the rest of
828828
# the steps in a workflow:
829-
# https://help.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable
829+
# https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
830830
out.write(" - name: Export boost environment\n")
831831
out.write(
832-
' run: "echo ::set-env name=BOOST_ROOT::%BOOST_ROOT_1_69_0%"\n'
832+
' run: "echo BOOST_ROOT=%BOOST_ROOT_1_69_0% >> %GITHUB_ENV%"\n'
833833
)
834834
out.write(" shell: cmd\n")
835835

0 commit comments

Comments
 (0)