fix use before assignment case

genevievehelsel · facebook-github-bot · commit a2244d67f478 · 2020-09-30T13:38:29.000-07:00
Summary: If retries is 0, then `0 &lt; 0` is false, meaning we will skip the `while` loop completely and just try to read retcode, which was never assigned.

Reviewed By: fanzeyi

Differential Revision: D23999523

fbshipit-source-id: fac4a1104eba3585fb52fc8d83163cb1a87b8fee
diff --git a/build/fbcode_builder/getdeps/builder.py b/build/fbcode_builder/getdeps/builder.py
@@ -709,7 +709,7 @@ def list_tests():
                 args += ["-R", test_filter]
 
             count = 0
-            while count < retry:
+            while count <= retry:
                 retcode = self._run_cmd(
                     args, env=env, use_cmd_prefix=use_cmd_prefix, allow_fail=True
                 )

Original file line number	Diff line number	Diff line change
`@@ -709,7 +709,7 @@ def list_tests():`
`709`	`709`	`args += ["-R", test_filter]`
`710`	`710`
`711`	`711`	`count = 0`
`712`		`- while count < retry:`
	`712`	`+ while count <= retry:`
`713`	`713`	`retcode = self._run_cmd(`
`714`	`714`	`args, env=env, use_cmd_prefix=use_cmd_prefix, allow_fail=True`
`715`	`715`	`)`