Skip to content

Commit 9641963

Browse files
lexsfacebook-github-bot
authored andcommitted
Remove noisy logs
Summary: These don't provide any value as we use a bunch of SubscriberBases all over. Rather than bump the level it makes sense to just remove them. If somebody feels this has value for debugging they can add them back locally. Reviewed By: alexmalyshev Differential Revision: D4929777 fbshipit-source-id: e562e5b48ca8f611469932f7fd132818f97da940
1 parent 5cfd385 commit 9641963

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

src/SubscriberBase.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ class SubscriberBaseT : public Subscriber<T>,
100100
std::shared_ptr<Subscription> subscription) noexcept override final {
101101
auto thisPtr = this->shared_from_this();
102102
runInExecutor([thisPtr, subscription]() {
103-
VLOG(1) << static_cast<ExecutorBase*>(thisPtr.get()) << " onSubscribe";
104103
CHECK(!thisPtr->originalSubscription_);
105104
thisPtr->originalSubscription_ = std::move(subscription);
106105
// if the subscription got cancelled in the meantime, we will not try to
@@ -116,7 +115,6 @@ class SubscriberBaseT : public Subscriber<T>,
116115
auto movedPayload = folly::makeMoveWrapper(std::move(payload));
117116
auto thisPtr = this->shared_from_this();
118117
runInExecutor([thisPtr, movedPayload]() mutable {
119-
VLOG(1) << static_cast<ExecutorBase*>(thisPtr.get()) << " onNext";
120118
if (!thisPtr->cancelled_) {
121119
thisPtr->onNextImpl(movedPayload.move());
122120
}
@@ -126,7 +124,6 @@ class SubscriberBaseT : public Subscriber<T>,
126124
void onComplete() noexcept override final {
127125
auto thisPtr = this->shared_from_this();
128126
runInExecutor([thisPtr]() {
129-
VLOG(1) << static_cast<ExecutorBase*>(thisPtr.get()) << " onComplete";
130127
if (!thisPtr->cancelled_.exchange(true)) {
131128
thisPtr->onCompleteImpl();
132129

@@ -141,7 +138,6 @@ class SubscriberBaseT : public Subscriber<T>,
141138
auto movedEx = folly::makeMoveWrapper(std::move(ex));
142139
auto thisPtr = this->shared_from_this();
143140
runInExecutor([thisPtr, movedEx]() mutable {
144-
VLOG(1) << static_cast<ExecutorBase*>(thisPtr.get()) << " onError";
145141
if (!thisPtr->cancelled_.exchange(true)) {
146142
thisPtr->onErrorImpl(movedEx.move());
147143

src/SubscriptionBase.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,13 @@ class SubscriptionBase : public Subscription,
2424
void request(size_t n) noexcept override final {
2525
auto thisPtr = this->shared_from_this();
2626
runInExecutor([thisPtr, n]() {
27-
VLOG(1) << static_cast<ExecutorBase*>(thisPtr.get()) << " request";
2827
thisPtr->requestImpl(n);
2928
});
3029
}
3130

3231
void cancel() noexcept override final {
3332
auto thisPtr = this->shared_from_this();
3433
runInExecutor([thisPtr]() {
35-
VLOG(1) << static_cast<ExecutorBase*>(thisPtr.get()) << " cancel";
3634
thisPtr->cancelImpl();
3735
});
3836
}

0 commit comments

Comments
 (0)