Merge pull request #2249 from swamp09/fix_columns_for_distinct

yahonda · web-flow · commit fa6cda6a465f · 2022-01-20T18:27:19.000+09:00
diff --git a/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb b/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb
@@ -662,7 +662,7 @@ def columns_for_distinct(columns, orders) # :nodoc:
           }.reject(&:blank?).map.with_index { |column, i|
             "FIRST_VALUE(#{column}) OVER (PARTITION BY #{columns} ORDER BY #{column}) AS alias_#{i}__"
           }
-        [super, *order_columns].join(", ")
+        (order_columns << super).join(", ")
       end
 
       def temporary_table?(table_name) # :nodoc:

Original file line number	Diff line number	Diff line change
`@@ -662,7 +662,7 @@ def columns_for_distinct(columns, orders) # :nodoc:`
`662`	`662`	`}.reject(&:blank?).map.with_index { \|column, i\|`
`663`	`663`	`"FIRST_VALUE(#{column}) OVER (PARTITION BY #{columns} ORDER BY #{column}) AS alias_#{i}__"`
`664`	`664`	`}`
`665`		`- [super, *order_columns].join(", ")`
	`665`	`+ (order_columns << super).join(", ")`
`666`	`666`	`end`
`667`	`667`
`668`	`668`	`def temporary_table?(table_name) # :nodoc:`