fix(http): check for single profile before creating dir + config

Author: niklaslong

http/src/config.rs

@@ -60,6 +60,16 @@ pub fn initialize(
     bits: NonZeroU16,
     profiles: Vec<Profile>,
 ) -> Result<(), InitializationError> {
+    // This check is done here to avoid an empty config file being created in the case of an
+    // unsupported input.
+    if profiles.len() != 1 {
+        // profiles are expected to be (comma separated) "test" as there are no bootstrap peer
+        // handling yet. the conformance test cases seem to init `go-ipfs` in this profile where
+        // it does not have any bootstrap nodes, and multi node tests later call swarm apis to
+        // dial the nodes together.
+        unimplemented!("Multiple profiles are currently unsupported!");
+    }
+
     let config_path = ipfs_path.join("config");
 
     fs::create_dir_all(&ipfs_path)
@@ -79,6 +89,11 @@ fn create(
     use prost::Message;
     use std::io::BufWriter;
 
+    let api_addrs = match profiles[0] {
+        Profile::Test => "127.0.0.1:0",
+        Profile::Default => "127.0.0.1:4004",
+    };
+
     let bits = bits.get();
 
     if bits < 2048 || bits > 16 * 1024 {
@@ -124,19 +139,6 @@ fn create(
 
     let private_key = Base64Pad.encode(&private_key);
 
-    if profiles.len() != 1 {
-        // profiles are expected to be (comma separated) "test" as there are no bootstrap peer
-        // handling yet. the conformance test cases seem to init `go-ipfs` in this profile where
-        // it does not have any bootstrap nodes, and multi node tests later call swarm apis to
-        // dial the nodes together.
-        unimplemented!("Multiple profiles are currently unsupported!")
-    }
-
-    let api_addrs = match profiles[0] {
-        Profile::Test => "127.0.0.1:0",
-        Profile::Default => "127.0.0.1:4004",
-    };
-
     let config_contents = CompatibleConfigFile {
         identity: Identity {
             peer_id,

http/src/main.rs

@@ -19,7 +19,7 @@ enum Options {
         /// List of configuration profiles to apply. Currently only the `Test` and `Default`
         /// profiles are supported.  
         ///
-        /// `Test` uses ephemeral ports, `Default` uses `4004`.
+        /// `Test` uses ephemeral ports (necessary for conformance tests), `Default` uses `4004`.
         #[structopt(long, use_delimiter = true)]
         profile: Vec<config::Profile>,
     },
@@ -157,11 +157,6 @@ fn main() {
 
         let api_link_file = home.join("api");
 
-        // If the port is specified, use that to start the server, if it isn't use ephemeral ports,
-        // i.e.:
-        //
-        // port => port
-        // none => 0
         let (addr, server) = serve(&ipfs, api_listening_addrs);
 
         // shutdown future will handle signalling the exit