Skip to content

Commit e66f2af

Browse files
committed
Rebase fixes. Fix library lincage and include_dirs for bases lib.
Add '_check_fields' as a default value in a __slots__ list for generated messages. Signed-off-by: EsipovPA <[email protected]>
1 parent 229eb34 commit e66f2af

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

rosidl_generator_py/cmake/rosidl_generator_py_generate_interfaces.cmake

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -191,22 +191,30 @@ endif()
191191
rosidl_get_typesupport_target(c_typesupport_target "${rosidl_generate_interfaces_TARGET}" "rosidl_typesupport_c")
192192
target_link_libraries(${_target_name_lib} PRIVATE ${c_typesupport_target})
193193

194-
195194
set(_target_name_bases_lib "${rosidl_generate_interfaces_TARGET}__bases")
196195
add_library(${_target_name_bases_lib} SHARED ${_generated_c_base_files})
197196
add_dependencies(
198197
${_target_name_bases_lib}
199198
${rosidl_generate_interfaces_TARGET}${_target_suffix})
200-
target_link_libraries(${_target_name_bases_lib} ${PythonExtra_LIBRARIES})
201-
target_include_directories(${_target_name_bases_lib} PRIVATE ${PythonExtra_INCLUDE_DIRS})
199+
target_link_libraries(
200+
${_target_name_bases_lib}
201+
Python3::NumPy
202+
Python3::Python
203+
${PythonExtra_LIBRARIES}
204+
)
205+
target_include_directories(
206+
${_target_name_bases_lib} PRIVATE
207+
${CMAKE_CURRENT_BINARY_DIR}/rosidl_generator_c
208+
${CMAKE_CURRENT_BINARY_DIR}/rosidl_generator_py
209+
${PythonExtra_INCLUDE_DIRS}
210+
)
202211

203212
set_target_properties(${_target_name_bases_lib} PROPERTIES
204213
COMPILE_OPTIONS "${_extension_compile_flags}"
205214
PREFIX ""
206215
LIBRARY_OUTPUT_DIRECTORY${_build_type} ${_output_path}
207216
RUNTIME_OUTPUT_DIRECTORY${_build_type} ${_output_path}
208217
OUTPUT_NAME "_${PROJECT_NAME}_bases${PythonExtra_EXTENSION_SUFFIX}"
209-
SUFFIX "${PythonExtra_EXTENSION_EXTENSION}"
210218
)
211219
if(NOT rosidl_generate_interfaces_SKIP_INSTALL)
212220
install(TARGETS ${_target_name_bases_lib}

rosidl_generator_py/resource/_msg.py.em

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ class @(message.structure.namespaced_type.name)(_bases.@(message.structure.names
230230

231231
# This field is modified after class creation.
232232
# See the comment to Metaclass_@(message.structure.namespaced_type.name).__new__
233-
__slots__ = []
233+
__slots__ = ['_check_fields']
234234

235235
_fields_and_field_types = {
236236
@[for member in message.structure.members]@

0 commit comments

Comments
 (0)