Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rosed and roscd equivalent in ros2cli #483

Closed
Briancbn opened this issue Apr 12, 2020 · 4 comments
Closed

rosed and roscd equivalent in ros2cli #483

Briancbn opened this issue Apr 12, 2020 · 4 comments
Labels
question Further information is requested

Comments

@Briancbn
Copy link

Feature request

Feature description

A ros2edit and ros2cd package that can easily navigate and edit the workspace source folder, like how rosed and roscd can do in ROS 1, which was a huge convenience for me when there was no gui.

Implementation considerations

Most of the implementation will be similar to ros2run, but there will be a need to locate package path inside the workspace instead of the index space, I find that colcon list can return the information, but might be too slow and colcon have their own common extensions(open for suggestions).

I think ROS_WORKSPACE will also need to be specified, but without it we can look for packages from the current path.

I can try and write up a pr, but please let me know if it is needed or you have any suggestions.

@dirk-thomas dirk-thomas added the question Further information is requested label Apr 14, 2020
@dirk-thomas
Copy link
Member

dirk-thomas commented Apr 14, 2020

Please see #75 which describes why a roscd command isn't available and that colcon_cd (colcon/colcon-cd#1) provides an alternative.

For rosed the challenges are very similar than for roscd. I am not sure if it makes sense to implement something like this as a colcon extension (similar to colcon_cd).

@Briancbn
Copy link
Author

Briancbn commented Apr 14, 2020

@dirk-thomas Yes it makes much more sense actually. I think I will try to do it as a colcon extension.

@hidmic
Copy link
Contributor

hidmic commented Apr 16, 2020

@dirk-thomas @Briancbn would it make sense to close this issue / transfer it to a colcon repo?

@dirk-thomas
Copy link
Member

I will go ahead with closing the ticket here.

@Briancbn Please feel free to contribute to colcon. If the addition is in form of a new repo please create it under your own GitHub user and when it is ready we can move it into the colcon org unit (as per recommendation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants