Skip to content

Commit d5d5010

Browse files
committed
address pr comments
Signed-off-by: Brian Chen <[email protected]>
1 parent b037bc5 commit d5d5010

File tree

1 file changed

+0
-4
lines changed
  • ros2param/ros2param/verb

1 file changed

+0
-4
lines changed

ros2param/ros2param/verb/set.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ class RequireParameterPairAction(argparse.Action):
3535
def __call__(self, parser, args, values, option_string=None):
3636
if len(values) == 0:
3737
parser.error('No parameters specified')
38-
SystemExit(2)
3938
if len(values) % 2:
4039
parser.error('Must provide parameter name and value pairs')
4140
setattr(args, self.dest, values)
@@ -61,21 +60,18 @@ def add_arguments(self, parser, cli_name): # noqa: D102
6160

6261
def build_parameters(self, params):
6362
parameters = []
64-
6563
for i in range(0, len(params), 2):
6664
parameter = Parameter()
6765
parameter.name = params[i]
6866
parameter.value = get_parameter_value(string_value=params[i+1])
6967
parameters.append(parameter)
70-
7168
return parameters
7269

7370
def main(self, *, args): # noqa: D102
7471
with NodeStrategy(args) as node:
7572
node_names = get_node_names(
7673
node=node, include_hidden_nodes=args.include_hidden_nodes)
7774
node_name = get_absolute_node_name(args.node_name)
78-
7975
if node_name not in {n.full_name for n in node_names}:
8076
return 'Node not found'
8177

0 commit comments

Comments
 (0)