Skip to content

Commit c7c1cba

Browse files
committed
Rename remove_callback to set_inert
Signed-off-by: Michael X. Grey <[email protected]>
1 parent 464d5d9 commit c7c1cba

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

rclrs/src/timer.rs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ impl Timer {
147147
/// See also:
148148
/// * [`Self::set_repeating`]
149149
/// * [`Self::set_oneshot`]
150-
/// * [`Self::remove_callback`].
150+
/// * [`Self::set_inert`].
151151
pub fn set_callback(&self, callback: AnyTimerCallback) -> Option<AnyTimerCallback> {
152152
self.callback.lock().unwrap().replace(callback)
153153
}
@@ -156,7 +156,7 @@ impl Timer {
156156
///
157157
/// See also:
158158
/// * [`Self::set_oneshot`]
159-
/// * [`Self::remove_callback`]
159+
/// * [`Self::set_inert`]
160160
pub fn set_repeating<Args>(
161161
&self,
162162
f: impl TimerCallRepeating<Args>,
@@ -173,17 +173,21 @@ impl Timer {
173173
///
174174
/// See also:
175175
/// * [`Self::set_repeating`]
176-
/// * [`Self::remove_callback`]
176+
/// * [`Self::set_inert`]
177177
pub fn set_oneshot<Args>(&self, f: impl TimerCallOnce<Args>) -> Option<AnyTimerCallback> {
178178
self.set_callback(f.into_oneshot_timer_callback())
179179
}
180180

181181
/// Remove the callback from the timer.
182182
///
183+
/// This does not cancel the timer; it will continue to wake up and be
184+
/// triggered at its regular period. However, nothing will happen when the
185+
/// timer is triggered until you give a new callback to the timer.
186+
///
183187
/// You can give the timer a new callback at any time by calling:
184188
/// * [`Self::set_repeating`]
185189
/// * [`Self::set_oneshot`]
186-
pub fn remove_callback(&self) -> Option<AnyTimerCallback> {
190+
pub fn set_inert(&self) -> Option<AnyTimerCallback> {
187191
self.set_callback(AnyTimerCallback::None)
188192
}
189193

0 commit comments

Comments
 (0)