Implicitly cast &str to NodeOptions

Signed-off-by: Michael X. Grey <[email protected]>

Author: mxgrey

rclrs/src/executor.rs

@@ -1,5 +1,5 @@
 use crate::{
-    rcl_bindings::rcl_context_is_valid, ContextHandle, Node, NodeOptions, RclrsError, WaitSet,
+    rcl_bindings::rcl_context_is_valid, ContextHandle, IntoNodeOptions, Node, RclrsError, WaitSet,
     WeakNode,
 };
 use std::{
@@ -15,8 +15,11 @@ pub struct Executor {
 
 impl Executor {
     /// Create a [`Node`] that will run on this Executor.
-    pub fn create_node(&self, options: impl Into<NodeOptions>) -> Result<Node, RclrsError> {
-        let options: NodeOptions = options.into();
+    pub fn create_node<'a>(
+        &'a self,
+        options: impl IntoNodeOptions<'a>,
+    ) -> Result<Node, RclrsError> {
+        let options = options.into_node_options();
         let node = options.build(&self.context)?;
         self.nodes_mtx.lock().unwrap().push(node.downgrade());
         Ok(node)

rclrs/src/node.rs

@@ -156,11 +156,11 @@ impl Node {
     ///
     /// # Example
     /// ```
-    /// # use rclrs::{Context, InitOptions, RclrsError, NodeOptions};
+    /// # use rclrs::{Context, InitOptions, RclrsError, IntoNodeOptions};
     /// // Without remapping
     /// let executor = Context::default().create_basic_executor();
     /// let node = executor.create_node(
-    ///     NodeOptions::new("my_node")
+    ///     "my_node"
     ///     .namespace("/my/namespace")
     /// )?;
     /// assert_eq!(node.namespace(), "/my/namespace");
@@ -182,10 +182,10 @@ impl Node {
     ///
     /// # Example
     /// ```
-    /// # use rclrs::{Context, RclrsError, NodeOptions};
+    /// # use rclrs::{Context, RclrsError, IntoNodeOptions};
     /// let executor = Context::default().create_basic_executor();
     /// let node = executor.create_node(
-    ///     NodeOptions::new("my_node")
+    ///     "my_node"
     ///     .namespace("/my/namespace")
     /// )?;
     /// assert_eq!(node.fully_qualified_name(), "/my/namespace/my_node");