Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to watchdog repository #28

Open
gbiggs opened this issue Sep 16, 2020 · 3 comments
Open

Add unit tests to watchdog repository #28

gbiggs opened this issue Sep 16, 2020 · 3 comments

Comments

@gbiggs
Copy link
Contributor

gbiggs commented Sep 16, 2020

No description provided.

@robbel
Copy link

robbel commented Oct 7, 2020

Hi @norro, I believe we spoke about this a while ago. Curious if that would still fit on your radar to add unit tests to the https://github.com/ros-safety/software_watchdogs repository? Happy to discuss here or in the next safety working group.

@norro
Copy link
Contributor

norro commented Oct 9, 2020

Hey @robbel. Yes, this is still on my radar and I still intend to do it. However, there are processes within my company that I have to wait for in order to contribute publicly (sounds ridiculous, I know, I'm sorry, but that's the way it is).

I hope that I can start on this within the next two weeks or so. If you need to have this earlier, I can only point you to the test setup I created for the ROS 2 diagnostic_aggregator. I believe that especially the output tests are close to what we want to have here as well, i.e.: test fixture for/with watchdogs and then monitoring their output. Do you agree?

@robbel
Copy link

robbel commented Oct 9, 2020

Thanks @norro , much appreciate the background. And I would agree that the general setup would be the same for the watchdogs as well-- in my (yet to be completely formed) mental model for the tests there would be a monitored process launched for a couple seconds, followed by their shutdown, and a test that the watchdog process transitions properly (it's itself a managed node) within a certain time interval. The next two weeks actually don't sound too bad for us, so maybe we'll just pick up the conversation then. Best!

norro added a commit to boschresearch/software_watchdogs that referenced this issue Apr 14, 2021
* Talker, heartbeat, and watchdog are launched
* When heartbeat and watchdog are in sync, heartbeat and talker are shut
down
* Proper reaction by watchdog (going nactive) is monitored

ros-safety/safety_working_group#28
ros-safety/safety_working_group#30

Signed-off-by: Nordmann Arne (CR/ADT3) <[email protected]>
norro added a commit to boschresearch/software_watchdogs that referenced this issue Apr 14, 2021
* Talker, heartbeat, and watchdog are launched
* When heartbeat and watchdog are in sync, heartbeat and talker are shut
down
* Proper reaction by watchdog (going nactive) is monitored

ros-safety/safety_working_group#28
ros-safety/safety_working_group#30

Signed-off-by: Nordmann Arne (CR/ADT3) <[email protected]>
norro added a commit to boschresearch/software_watchdogs that referenced this issue Apr 14, 2021
* Talker, heartbeat, and watchdog are launched
* When heartbeat and watchdog are in sync, heartbeat and talker are shut
down
* Proper reaction by watchdog (going nactive) is monitored

ros-safety/safety_working_group#28
ros-safety/safety_working_group#30

Signed-off-by: Nordmann Arne (CR/ADT3) <[email protected]>
norro added a commit to boschresearch/software_watchdogs that referenced this issue Apr 14, 2021
* Talker, heartbeat, and watchdog are launched
* When heartbeat and watchdog are in sync, heartbeat and talker are shut
down
* Proper reaction by watchdog (going nactive) is monitored

ros-safety/safety_working_group#28
ros-safety/safety_working_group#30

Signed-off-by: Nordmann Arne (CR/ADT3) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants