-
Notifications
You must be signed in to change notification settings - Fork 376
feat(rqt): Add update rate and async info to details window #2510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(rqt): Add update rate and async info to details window #2510
Conversation
Adds update_rate and is_async parameters to the RQT controller manager details popup. Fetches per-controller parameters and falls back to global/default values if not available. Fixes ros-controls#2166.
|
@ShahazadAbdulla could you please reattempt uploading the screenshot? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2510 +/- ##
=======================================
Coverage 89.60% 89.60%
=======================================
Files 152 152
Lines 17637 17637
Branches 1448 1448
=======================================
Hits 15804 15804
Misses 1250 1250
Partials 583 583
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ofc. @bmagyar
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
I tested it, and it works for controllers, but: The same layout is used for controllers and hardware components, but you only query the parameters from the controllers. If you later open the details of a hardware component, the data is wrong because not updated/deleted any more.
Please consider a consistent code style (comments), and remove LLM output
rqt_controller_manager/rqt_controller_manager/controller_manager.py
Outdated
Show resolved
Hide resolved
rqt_controller_manager/rqt_controller_manager/controller_manager.py
Outdated
Show resolved
Hide resolved
rqt_controller_manager/rqt_controller_manager/controller_manager.py
Outdated
Show resolved
Hide resolved
rqt_controller_manager/rqt_controller_manager/controller_manager.py
Outdated
Show resolved
Hide resolved
rqt_controller_manager/rqt_controller_manager/controller_manager.py
Outdated
Show resolved
Hide resolved
rqt_controller_manager/rqt_controller_manager/controller_manager.py
Outdated
Show resolved
Hide resolved
rqt_controller_manager/rqt_controller_manager/controller_manager.py
Outdated
Show resolved
Hide resolved
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
…er.py Co-authored-by: Christoph Fröhlich <[email protected]>
…er.py Co-authored-by: Christoph Fröhlich <[email protected]>
…er.py Co-authored-by: Christoph Fröhlich <[email protected]>
…er.py Co-authored-by: Christoph Fröhlich <[email protected]>
…er.py Co-authored-by: Christoph Fröhlich <[email protected]>
…er.py Co-authored-by: Christoph Fröhlich <[email protected]>
…er.py Co-authored-by: Christoph Fröhlich <[email protected]>
|
|
Hi @christophfroehlich , I was looking into the failing "Kilted" check to see if there was anything I needed to fix. It seems the failure is happening in the test_spawner_unspawner test. Based on the job logs, the root cause appears to be an issue within the test setup itself, related to service timeouts and spawner scripts being called with missing arguments. This seems to be an existing issue in the master branch that was revealed when you merged it into my branch. This appears to be completely unrelated to my RQT changes, but I wanted to share my findings in case it's helpful for tracking down the problem. Please let me know if there's anything else you need from my side for this PR. Also what should I do next on this. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry about this failing test, this is not related. But you haven't addressed my concern regarding update of the hardware components, please do so.


Fixes #2166
This PR adds the
update_rateandis_asyncparameters to the RQT controller manager details popup window.Implementation Details:
popup_info.uito add new QLabel widgets for displaying the information._on_ctrl_infofunction incontroller_manager.pyto fetch the parameters usingros2param.api.call_get_parameters.<controller_name>.update_rate, etc.).update_rateor a sensible default (Falseforis_async).Testing:
rrbotdemo fromros2_control_demos, the popup correctly displays the global and default values as shown below.Result: