Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shiny app for populating metadata files #22

Closed
aurielfournier opened this issue May 22, 2018 · 18 comments
Closed

shiny app for populating metadata files #22

aurielfournier opened this issue May 22, 2018 · 18 comments
Assignees
Milestone

Comments

@aurielfournier
Copy link
Collaborator

I'm starting to work on a shiny app to take the generated metadata templates and make them such that a user who does not know R, can populate them with the needed details.

@aurielfournier
Copy link
Collaborator Author

#27 we now have a shiny app that allows the user to fill in some of the cells and write out a file.

@aurielfournier
Copy link
Collaborator Author

But we need to make it so that it writes out a .csv

Right now it does ASCII and RDS.

@khondula
Copy link
Contributor

for bounding box/spatial coverage, mapedit might be useful https://www.r-spatial.org/r/2017/06/09/mapedit_0-2-0.html to create a new spatial extent, or display a bounding box based on min/max coordinates in the dataset

@aurielfournier
Copy link
Collaborator Author

@khondula would that be for a shiny app for users to define their bounding box? Instead of entering the numeric values?

@aurielfournier
Copy link
Collaborator Author

It now outputs a .csv file of the populated attributes.csv metadata file.

Next up is the biblio, access and creators.csv apps.

this could be done with a tabbed shiny app or four separate apps.

@aurielfournier
Copy link
Collaborator Author

#36 #38 #35 creates the new shiny apps for creator, biblio, access shiny apps

@aurielfournier
Copy link
Collaborator Author

Next step would be bringing all of these together into one app.

@aurielfournier aurielfournier self-assigned this May 23, 2018
@khondula
Copy link
Contributor

I think these functions might need to be added to the namespace?

would that be for a shiny app for users to define their bounding box?

@aurielfournier yes, maybe showing them what the bounds are if they have coordinates entered (so they can confirm no silly lat/lon errors), or if they don't know coordinates they can draw a box like on http://geojson.io/

@aurielfournier
Copy link
Collaborator Author

Gotcha! I can work on the bounding box as well.

And yes, you are right, I forgot to add them. Will work on it shortly

@khondula
Copy link
Contributor

might be good to coordinate with @amoeba re: #41

@amoeba
Copy link
Collaborator

amoeba commented May 24, 2018

Sounds good @aurielfournier @khondula!

@amoeba
Copy link
Collaborator

amoeba commented May 25, 2018

I just ran through these and they look great @aurielfournier! I'm so glad you sat down and joined us on day two.

I had an idea while I was using them I thought I'd run by you. Is this the right workflow to, for example, edit the access metadata?

access_df <- read.csv("data/metadata/access.csv", stringsAsFactors = FALSE)
editAccess(access_df)

What do you think about defaulting to doing the first line for the user by assuming each of the CSVs is at the conventional path (./data/metadata/{type}.csv) so the user only has to do this to get their data spiced?

create_spice()
editBiblio()
editAccess()
editAttributes()
editCreators()
write_spice()
build_site()

Also, would it be alright if I renamed these functions to use snake_case instead of camelCase just for consistency's sake?

@annakrystalli
Copy link
Collaborator

Was just about to add the suggestion above by @amoeba.

My suggestion would be for the function to take an argument for the path to the file that is to be edited but for the argument to default to here::here("data", "metadata", {type}.csv). The function would then read and write the file back out using that path.

@aurielfournier
Copy link
Collaborator Author

You are right @amoeba that is how its currently written, but I agree with you and @annakrystalli it would make more sense to have the function do all that for the user. I shall get that done over the weekend!

@amoeba
Copy link
Collaborator

amoeba commented May 25, 2018

Most excellent!

@annakrystalli
Copy link
Collaborator

annakrystalli commented May 26, 2018

🙌

BTW, we've already got readr as a dependency and have been using readr::read_csv() readr::write_csv() in other functions so far. Not necessary to use these but might be more consistent if we do use throughout?

@amoeba
Copy link
Collaborator

amoeba commented May 26, 2018

Good catch! I'm fine with using readr everywhere.

@amoeba
Copy link
Collaborator

amoeba commented Jul 21, 2020

This is "in" as of #60. Thanks @aurielfournier and @annakrystalli. We might find things to improve now that all of this is in but I think we can use new issues for those.

@amoeba amoeba closed this as completed Jul 21, 2020
@amoeba amoeba added this to the v1.0 milestone Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants