Release v2.19.2

Author: waltjones

README.md

@@ -1,7 +1,7 @@
 # Rollbar.js
 
 
-[![Build Status](https://travis-ci.org/rollbar/rollbar.js.svg?branch=v2.19.1)](https://travis-ci.org/rollbar/rollbar.js)
+[![Build Status](https://travis-ci.org/rollbar/rollbar.js.svg?branch=v2.19.2)](https://travis-ci.org/rollbar/rollbar.js)
 [![Code Quality: Javascript](https://img.shields.io/lgtm/grade/javascript/g/rollbar/rollbar.js.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/rollbar/rollbar.js/context:javascript)
 [![Total Alerts](https://img.shields.io/lgtm/alerts/g/rollbar/rollbar.js.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/rollbar/rollbar.js/alerts)
 

dist/rollbar.js

@@ -4185,7 +4185,6 @@ function addDiagnosticKeys(item, options, callback) {
 
   if (item._isUncaught) {
     diagnostic.is_uncaught = item._isUncaught;
-    delete item._isUncaught;
   }
 
   if (item.err) {
@@ -4264,6 +4263,7 @@ function checkLevel(item, settings) {
 function userCheckIgnore(logger) {
   return function(item, settings) {
     var isUncaught = !!item._isUncaught;
+    delete item._isUncaught;
     var args = item._originalArgs;
     delete item._originalArgs;
     try {
@@ -4429,7 +4429,7 @@ module.exports = {
 
 
 module.exports = {
-  version: '2.19.1',
+  version: '2.19.2',
   endpoint: 'api.rollbar.com/api/1/item/',
   logLevel: 'debug',
   reportLevel: 'debug',
@@ -4871,15 +4871,20 @@ Instrumenter.prototype.instrumentNetwork = function() {
     replace(xhrp, 'open', function(orig) {
       return function(method, url) {
         if (_.isType(url, 'string')) {
-          this.__rollbar_xhr = {
-            method: method,
-            url: url,
-            status_code: null,
-            start_time_ms: _.now(),
-            end_time_ms: null
-          };
-          if (self.autoInstrument.networkRequestHeaders) {
-            this.__rollbar_xhr.request_headers = {};
+          if (this.__rollbar_xhr) {
+            this.__rollbar_xhr.method = method;
+            this.__rollbar_xhr.url = url;
+            this.__rollbar_xhr.status_code = null;
+            this.__rollbar_xhr.start_time_ms = _.now();
+            this.__rollbar_xhr.end_time_ms = null;
+          } else {
+            this.__rollbar_xhr = {
+              method: method,
+              url: url,
+              status_code: null,
+              start_time_ms: _.now(),
+              end_time_ms: null
+            };
           }
         }
         return orig.apply(this, arguments);
@@ -4888,12 +4893,21 @@ Instrumenter.prototype.instrumentNetwork = function() {
 
     replace(xhrp, 'setRequestHeader', function(orig) {
       return function(header, value) {
-        if (self.autoInstrument.networkRequestHeaders && this.__rollbar_xhr &&
-          _.isType(header, 'string') && _.isType(value, 'string')) {
-          this.__rollbar_xhr.request_headers[header] = value;
+        // If xhr.open is async, __rollbar_xhr may not be initialized yet.
+        if (!this.__rollbar_xhr) {
+          this.__rollbar_xhr = {};
         }
-        if (header.toLowerCase() === 'content-type') {
-          this.__rollbar_xhr.request_content_type = value;
+        if (_.isType(header, 'string') && _.isType(value, 'string')) {
+          if (self.autoInstrument.networkRequestHeaders) {
+            if (!this.__rollbar_xhr.request_headers) {
+              this.__rollbar_xhr.request_headers = {};
+            }
+            this.__rollbar_xhr.request_headers[header] = value;
+          }
+          // We want the content type even if request header telemetry is off.
+          if (header.toLowerCase() === 'content-type') {
+            this.__rollbar_xhr.request_content_type = value;
+          }
         }
         return orig.apply(this, arguments);
       };