tweak eslint settings

Use the default complexity of 20 across the codebase, but exempt the
5 functions that push it above 20, prefer eslint-disable-next-line
when linting is disabled for a single line, and use the string constants
which are self explanitory rather than the number constants when
configuring eslintrc.

Author: terencehonles

.eslintrc

@@ -16,14 +16,14 @@
   ],
   "globals": { "Promise": true },
   "rules": {
-    "strict": 0,
-    "camelcase": [2, {"properties": "never"}],
-    "quotes": [2, "single", "avoid-escape"],
-    "no-underscore-dangle": 0,
-    "no-useless-escape": 0,
-    "complexity": [2, { "max": 35 }],
-    "no-use-before-define": [0, { "functions": false }],
-    "no-unused-vars": [2, { "argsIgnorePattern": "^_" }],
-    "no-prototype-builtins": 0
+    "strict": "off",
+    "camelcase": ["error", {"properties": "never"}],
+    "quotes": ["error", "single", "avoid-escape"],
+    "no-underscore-dangle": "off",
+    "no-useless-escape": "off",
+    "complexity": ["error"],
+    "no-use-before-define": ["off", { "functions": false }],
+    "no-unused-vars": ["error", { "argsIgnorePattern": "^_" }],
+    "no-prototype-builtins": "off"
   }
 }

src/browser/shim.js

@@ -7,9 +7,8 @@ function _wrapInternalErr(f) {
       return f.apply(this, arguments);
     } catch (e) {
       try {
-        /* eslint-disable no-console */
+        /* eslint-disable-next-line no-console */
         console.error('[Rollbar]: Internal error', e);
-        /* eslint-enable no-console */
       } catch (e2) {
         // Ignore
       }

src/browser/telemetry.js

@@ -120,7 +120,7 @@ Instrumenter.prototype.configure = function(options) {
   }
 };
 
-// eslint-disable-next-line complexity
+/* eslint-disable-next-line complexity */
 Instrumenter.prototype.instrument = function(oldSettings) {
   if (this.autoInstrument.network && !(oldSettings && oldSettings.network)) {
     this.instrumentNetwork();
@@ -222,11 +222,10 @@ Instrumenter.prototype.instrumentNetwork = function() {
     }, this.replacements, 'network');
 
     replace(xhrp, 'send', function(orig) {
-      /* eslint-disable no-unused-vars */
       return function(data) {
-      /* eslint-enable no-unused-vars */
         var xhr = this;
 
+        /* eslint-disable-next-line complexity */
         function onreadystatechangeHandler() {
           if (xhr.__rollbar_xhr) {
             if (xhr.__rollbar_xhr.status_code === null) {
@@ -331,9 +330,8 @@ Instrumenter.prototype.instrumentNetwork = function() {
 
   if ('fetch' in this._window) {
     replace(this._window, 'fetch', function(orig) {
-      /* eslint-disable no-unused-vars */
+      /* eslint-disable-next-line no-unused-vars */
       return function(fn, t) {
-      /* eslint-enable no-unused-vars */
         var args = new Array(arguments.length);
         for (var i=0, len=args.length; i < len; i++) {
           args[i] = arguments[i];

src/browser/transforms.js

@@ -210,6 +210,7 @@ function addBodyTrace(item, options, callback) {
   }
 }
 
+/* eslint-disable-next-line complexity */
 function buildTrace(item, stackInfo, options) {
   var description = item && item.data.description;
   var custom = item && item.custom;

src/server/transforms.js

@@ -104,6 +104,7 @@ function handleItemWithError(item, options, callback) {
   async.eachSeries(errors, _buildTraceData(chain, options, item), cb);
 }
 
+/* eslint-disable-next-line complexity */
 function addRequestData(item, options, callback) {
   item.data = item.data || {};
 

src/utility.js

@@ -379,6 +379,7 @@ function wrapCallback(logger, f) {
   };
 }
 
+/* eslint-disable-next-line complexity */
 function createItem(args, logger, notifier, requestKeys, lambdaContext) {
   var message, err, custom, callback, request;
   var arg;