editing README.md

Author: rohan-paul

README.md

@@ -8,9 +8,9 @@ The `master` branch has the code for AWS-S3 upload and the `disk-storage` branch
 
 First start mongodb service with `sudo service mongod start` and then the following commands
 
-- Run `npm install`
-- Run `npm run dev`
-- Run `npm start`
+-   Run `npm install`
+-   Run `npm run dev`
+-   Run `npm start`
 
 It will start the server at [http://localhost:3000/](http://localhost:3000/)
 
@@ -23,3 +23,41 @@ It will start the server at [http://localhost:3000/](http://localhost:3000/)
 This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app).
 
 [NOTE ONLY FOR ME - I HAVE TO ENTER ALL DETAILS IN .env FILE AGAIN AS I HAVE DELETED THE S3-BUCKET ]
+
+### How to make the AWS-S3 bucket public - whithout which the upload will NOT work
+
+If you're using an Amazon S3 bucket to share files with anyone else, you'll first need to make those files public. Maybe you're sending download links to someone, or perhaps you're using S3 for static files for your website or as a content delivery network (CDN). But if you don't make the files public, your users will get an XML error message saying the file is unavailable.
+
+1. Sign in to Amazon Web Services and go to your S3 Management Console.
+
+2. Select the bucket from the left. At right, click the Properties button if it's not already expanded.
+
+3. Go to the Permissions tab > Public Access Settings Tab
+
+4. Click on Edit > Then
+
+    A) `Block new public ACLs and uploading public objects (Recommended)` - Make it false (i.e. uncheck it)
+
+    B) `Block new public bucket policies (Recommended)` - Make it false (i.e. uncheck it)
+
+    C) `Block public and cross-account access if bucket has public policies (Recommended)` - Make it false (i.e. uncheck it)
+
+    D) `Block public and cross-account access if bucket has public policies (Recommended)` - Make it false (i.e. uncheck it) - Without this last action, althouh I was able to upload BUT was NOT able to download.
+
+So all the four options that was there (as on 24-Nov-2018) - I made all of them false.
+
+#### I can test the upload API from Postman by selecting `http://localhost:3000/api/document/upload` and > POST > Body > form-data > under Key type "file" and under Value select file and choose a file.
+
+And I will get back a 200 OK response of the below form-data
+
+{
+"data": {
+"ETag": "a number",
+"Location": "full link of the file",
+"key": "original file name of the file that I uploaded",
+"Key": "original file name of the file that I uploaded",
+"Bucket": "my AWS s3 bucket name"
+}
+}
+
+[Small note on .env file - When putting the value for "AWS_Uploaded_File_URL_LINK" - I have to include a forward slash ("/") after ]

package-lock.json

@@ -23,13 +23,13 @@
         "reactstrap": "^6.5.0"
     },
     "keywords": [
-    "nodejs",
-    "react",
-    "mongodb",
-    "multer",
-    "aws-sdk",
-    "AWS-S3"
-  ],
+        "nodejs",
+        "react",
+        "mongodb",
+        "multer",
+        "aws-sdk",
+        "AWS-S3"
+    ],
     "scripts": {
         "start": "react-scripts start",
         "build": "react-scripts build",
@@ -47,4 +47,4 @@
         "not ie <= 11",
         "not op_mini all"
     ]
-}
+}

package.json

@@ -3,13 +3,13 @@ import "./App.css";
 import FileUpload from "./Components/FileUpload";
 
 class App extends Component {
-  render() {
-    return (
-      <div className="App">
-        <FileUpload />
-      </div>
-    );
-  }
+	render() {
+		return (
+			<div className="App">
+				<FileUpload />
+			</div>
+		);
+	}
 }
 
 export default App;