[wpilibc] Make IsSimulation() checks constexpr (#2769)

calcmogul · web-flow · commit 1aa281a68276 · 2020-10-03T22:26:19.000-07:00
diff --git a/cpp/frc2/command/CommandScheduler.cpp b/cpp/frc2/command/CommandScheduler.cpp
@@ -193,7 +193,7 @@ void CommandScheduler::Run() {
   // Run the periodic method of all registered subsystems.
   for (auto&& subsystem : m_impl->subsystems) {
     subsystem.getFirst()->Periodic();
-    if (frc::RobotBase::IsSimulation()) {
+    if constexpr (frc::RobotBase::IsSimulation()) {
       subsystem.getFirst()->SimulationPeriodic();
     }
     m_watchdog.AddEpoch("Subsystem Periodic()");

Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,7 @@ void CommandScheduler::Run() {`
`193`	`193`	`// Run the periodic method of all registered subsystems.`
`194`	`194`	`for (auto&& subsystem : m_impl->subsystems) {`
`195`	`195`	`subsystem.getFirst()->Periodic();`
`196`		`- if (frc::RobotBase::IsSimulation()) {`
	`196`	`+ if constexpr (frc::RobotBase::IsSimulation()) {`
`197`	`197`	`subsystem.getFirst()->SimulationPeriodic();`
`198`	`198`	`}`
`199`	`199`	`m_watchdog.AddEpoch("Subsystem Periodic()");`