Remove PerpetualCommand

Author: virtuald

commands2/__init__.py

@@ -12,7 +12,6 @@
 from .parallelcommandgroup import ParallelCommandGroup
 from .paralleldeadlinegroup import ParallelDeadlineGroup
 from .parallelracegroup import ParallelRaceGroup
-from .perpetualcommand import PerpetualCommand
 from .pidcommand import PIDCommand
 from .pidsubsystem import PIDSubsystem
 from .printcommand import PrintCommand
@@ -46,7 +45,6 @@
     "ParallelCommandGroup",
     "ParallelDeadlineGroup",
     "ParallelRaceGroup",
-    "PerpetualCommand",
     "PIDCommand",
     "PIDSubsystem",
     "PrintCommand",

commands2/command.py

@@ -15,7 +15,6 @@
     from .sequentialcommandgroup import SequentialCommandGroup
     from .paralleldeadlinegroup import ParallelDeadlineGroup
     from .parallelcommandgroup import ParallelCommandGroup
-    from .perpetualcommand import PerpetualCommand
     from .repeatcommand import RepeatCommand
     from .proxycommand import ProxyCommand
     from .conditionalcommand import ConditionalCommand
@@ -341,27 +340,6 @@ def raceWith(self, *parallel: Command) -> ParallelRaceGroup:
 
         return ParallelRaceGroup(self, *parallel)
 
-    def perpetually(self) -> PerpetualCommand:
-        """
-        Decorates this command to run perpetually, ignoring its ordinary end conditions. The decorated
-        command can still be interrupted or canceled.
-
-        Note: This decorator works by adding this command to a composition. The command the
-        decorator was called on cannot be scheduled independently or be added to a different
-        composition (namely, decorators), unless it is manually cleared from the list of composed
-        commands with CommandScheduler#removeComposedCommand(Command). The command composition
-        returned from this method can be further decorated without issue.
-
-        :returns: the decorated command
-        @deprecated PerpetualCommand violates the assumption that execute() doesn't get called after
-            isFinished() returns true -- an assumption that should be valid. This was unsafe/undefined
-            behavior from the start, and RepeatCommand provides an easy way to achieve similar end
-            results with slightly different (and safe) semantics.
-        """
-        from .perpetualcommand import PerpetualCommand
-
-        return PerpetualCommand(self)
-
     def repeatedly(self) -> RepeatCommand:
         """
         Decorates this command to run repeatedly, restarting it when it ends, until this command is

commands2/perpetualcommand.py

@@ -127,16 +127,6 @@ def test_raceWith(scheduler: commands2.CommandScheduler):
     assert not group.isScheduled()
 
 
-def test_perpetually(scheduler: commands2.CommandScheduler):
-    command = commands2.InstantCommand()
-    perpetual = command.perpetually()
-    scheduler.schedule(perpetual)
-    scheduler.run()
-    scheduler.run()
-    scheduler.run()
-    assert perpetual.isScheduled()
-
-
 @pytest.mark.skipif(IS_OLD_COMMANDS, reason="not in old commands")
 def test_unless(scheduler: commands2.CommandScheduler):
     unlessCondition = OOBoolean(True)