-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests fail using ntcore backend #112
Comments
Took a look at this. Looks like we need to change line 20 of tests/conftest.py back to import from networktables, otherwise the utils will use a different backend to the test fixtures. |
This might also be an indicator that we should actually pass the NetworkTablesInstance to the util classes in the tests as well. |
This does run tests with ntcore. |
I believe early 2021 me was referring to the fact that none of the tests here will actually run against the ntcore backend, as the fixtures unconditionally use the pure-Python backend. Whilst I might agree that it's good to test that the pure-Python stuff still works with pyntcore installed, I'm not sure it's a good use of our CI time. |
The reason for adding this testing was because team code written in pure python started failing when swapped to the pyntcore back end. I guess with nt4 coming in 2023, it doesn't really matter all too much anymore. |
The following tests failed repeatedly on the ntcore backend:
The text was updated successfully, but these errors were encountered: