Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail using ntcore backend #112

Open
TheTripleV opened this issue Jul 21, 2020 · 6 comments
Open

Tests fail using ntcore backend #112

TheTripleV opened this issue Jul 21, 2020 · 6 comments

Comments

@TheTripleV
Copy link
Member

The following tests failed repeatedly on the ntcore backend:

  • test_util.py::test_ntproperty[True] - assert None == 0
  • test_util.py::test_ntproperty[False] - assert None == 0
  • test_util.py::test_ntproperty_multitest[True] - assert None == 0
  • test_util.py::test_ntproperty_multitest[False] - assert None == 0
  • test_util.py::test_chooser_control[True] - AssertionError: assert None...
  • test_util.py::test_chooser_control[False] - AssertionError: assert 'fo...
@auscompgeek
Copy link
Member

Took a look at this. Looks like we need to change line 20 of tests/conftest.py back to import from networktables, otherwise the utils will use a different backend to the test fixtures.

@auscompgeek
Copy link
Member

This might also be an indicator that we should actually pass the NetworkTablesInstance to the util classes in the tests as well.

@auscompgeek
Copy link
Member

Fixed by #115 and #118, but perhaps we should also make it possible to run the tests with the ntcore backend here?

@TheTripleV
Copy link
Member Author

This does run tests with ntcore.
The only issue is with some tests sporadically failing: https://github.com/robotpy/pynetworktables/actions/runs/498147113.
With the current matrix of size 32, jobs get queued making runs long.

@auscompgeek
Copy link
Member

This does run tests with ntcore.

I believe early 2021 me was referring to the fact that none of the tests here will actually run against the ntcore backend, as the fixtures unconditionally use the pure-Python backend. Whilst I might agree that it's good to test that the pure-Python stuff still works with pyntcore installed, I'm not sure it's a good use of our CI time.

@TheTripleV
Copy link
Member Author

The reason for adding this testing was because team code written in pure python started failing when swapped to the pyntcore back end. I guess with nt4 coming in 2023, it doesn't really matter all too much anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants