Fix typos in API, add limited tests for entry

Author: virtuald

ntcore/api.py

@@ -69,9 +69,6 @@ def getEntryTypeById(self, local_id):
     def getEntryValue(self, name):
         return self.storage.getEntryValue(name)
 
-    def getEntryValueById(self, local_id):
-        return self.storage.getEntryValueById(local_id)
-
     def setDefaultEntryValue(self, name, value):
         return self.storage.setDefaultEntryValue(name, value)
 
@@ -100,13 +97,13 @@ def getEntryFlags(self, name):
         return self.storage.getEntryFlags(name)
 
     def getEntryFlagsById(self, local_id):
-        return self.storage.getEntryFlags(local_id)
+        return self.storage.getEntryFlagsById(local_id)
 
     def deleteEntry(self, name):
         self.storage.deleteEntry(name)
 
     def deleteEntryById(self, local_id):
-        self.storage.deleteEntry(local_id)
+        self.storage.deleteEntryById(local_id)
 
     def deleteAllEntries(self):
         self.storage.deleteAllEntries()
@@ -188,7 +185,7 @@ def pollConnectionListener(self, poller_uid, timeout=None):
         return self.conn_notifier.poll(poller_uid, timeout=timeout)
 
     def cancelPollConnectionListener(self, poller_uid):
-        self.conn_notifier.cancelPoll()
+        self.conn_notifier.cancelPoll(poller_uid)
 
     def removeConnectionListener(self, listener_uid):
         self.conn_notifier.remove(listener_uid)

tests/test_entry.py

@@ -0,0 +1,32 @@
+#
+# Ensure that the NetworkTableEntry objects work
+#
+
+
+def test_entry_value(nt):
+    e = nt.getEntry("/k1")
+    assert e.getString(None) is None
+    e.setString("value")
+    assert e.getString(None) == "value"
+    e.delete()
+    assert e.getString(None) is None
+    e.setString("value")
+    assert e.getString(None) == "value"
+
+
+def test_entry_persistence(nt):
+    e = nt.getEntry("/k2")
+
+    for _ in range(2):
+
+        assert not e.isPersistent()
+        # persistent flag cannot be set unless the entry has a value
+        e.setString("value")
+
+        assert not e.isPersistent()
+        e.setPersistent()
+        assert e.isPersistent()
+        e.clearPersistent()
+        assert not e.isPersistent()
+
+        e.delete()