Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with inputs flattening in DDPG+HER #2091

Open
mazpie opened this issue Oct 7, 2020 · 2 comments
Open

Issue with inputs flattening in DDPG+HER #2091

mazpie opened this issue Oct 7, 2020 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@mazpie
Copy link

mazpie commented Oct 7, 2020

I am experiencing a problem with version v2020.06.3 training with DDPG+HER on the FetchReach-v1 environment.
Using the provided example, I get an index error:

IndexError: only integers, slices (:), ellipsis (...), numpy.newaxis (None) and integer or boolean arrays are valid indices

which comes from

File (...)/python3.7/site-packages/garage/tf/policies/continuous_mlp_policy.py", line 144, in get_actions observations = self.observation_space.flatten_n(observations)

from what I could see the problem comes from the fact that the OffPolicyVectorizedSampler already flattens the observations at line 113:

input_obses = obs_space.flatten_n(obses)

then, the observation_space used by the ContinuousMLPPolicy is different from the space of the observations received from the sampler.

@ryanjulian
Copy link
Member

@nicolengsy please triage!

@nicolengsy nicolengsy added the bug Something isn't working label Oct 10, 2020
@nicolengsy nicolengsy added this to the v2020.10.0rc7 milestone Oct 10, 2020
@nicolengsy
Copy link
Contributor

@mazpie Thanks for opening the issue, we'll be addressing it on our upcoming milestone!

@maliesa96 maliesa96 removed their assignment Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants