Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DQN is not learning #1774

Open
ahtsan opened this issue Jul 16, 2020 · 4 comments
Open

DQN is not learning #1774

ahtsan opened this issue Jul 16, 2020 · 4 comments
Assignees
@maliesa96
Labels
algos bug Something isn't working tf
Milestone
v2020.11.0

Comments

@ahtsan
Copy link
Contributor

ahtsan commented Jul 16, 2020

Would be great to be resolved along with #1773.
@ahtsan ahtsan added bug Something isn't working algos tf labels Jul 16, 2020
@ryanjulian ryanjulian added this to the v2020.09rc2 milestone Jul 16, 2020
@krzentner
Copy link
Contributor

Oh, this explains why refactoring the off-policy logging seemed to not be working for DQN.

@ahtsan
Copy link
Contributor Author

ahtsan commented Jul 24, 2020

For reference, 2020.06 version is still working (i.e. DQN is still learning)
https://github.com/rlworkgroup/garage/blob/v2020.06.0/examples/tf/dqn_cartpole.py

@ahtsan
Copy link
Contributor Author

ahtsan commented Jul 24, 2020

#1791 would probably help part of the issue.

@ryanjulian ryanjulian assigned maliesa96 and unassigned maliesa96 Jul 24, 2020
@maliesa96
Copy link
Contributor

This seems to be caused by #1353, though I haven't yet figured out what LocalSampler and Frag Worker are missing. I'll backport this fix once I figure it out.

@maliesa96 maliesa96 modified the milestones: v2020.09rc2, v2020.09rc3 Jul 31, 2020
@ryanjulian ryanjulian modified the milestones: v2020.09rc2, v2020.09rc3 Aug 3, 2020
@irisliucy irisliucy assigned irisliucy and unassigned irisliucy Aug 10, 2020
@ryanjulian ryanjulian modified the milestones: v2020.09rc3, v2020.09rc4 Aug 17, 2020
@ryanjulian ryanjulian modified the milestones: v2020.09rc4, v2020.09rc5 Aug 27, 2020
@ryanjulian ryanjulian modified the milestones: v2020.10.0rc7, v2020.10.0 Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maliesa96 maliesa96

Labels
algos bug Something isn't working tf
Projects
None yet
Milestone
v2020.11.0
Development

No branches or pull requests
5 participants
@ryanjulian @ahtsan @irisliucy @krzentner @maliesa96