Skip to content

Commit 1dcb6bb

Browse files
committed
final fixes for release
1 parent 97e0bee commit 1dcb6bb

File tree

5 files changed

+19
-36
lines changed

5 files changed

+19
-36
lines changed

R/check.R

+4-4
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
#'
4646
#' See \code{vignette("create_article", package = "rjtools")} for how to use the check functions
4747
#' @rdname checks
48-
#' @return list of all results (see \code{\link{log_error}} for
48+
#' @return list of all results (see \code{log_error} for
4949
#' details). You can use \code{unlist()} to get a character vector
5050
#' of the result statuses.
5151
#'
@@ -361,7 +361,7 @@ check_abstract_str <- function(str){
361361
# citation
362362
citations <- grepl("\\cite\\{.*\\}|\\citep|\\citet", str)
363363

364-
others <- grepl("\\texttt|\\$.*\\$|\\emph|\\proglang", str)
364+
others <- grepl("\\\\texttt|\\$.*\\$|\\\\emph|\\\\proglang", str)
365365

366366
any(c(pkgs, citations, others))
367367
}
@@ -772,8 +772,8 @@ log_factory <- function(result = c("SUCCESS", "NOTE", "WARNING", "ERROR")) {
772772
#' to an environment then the entry is also added to the journal.
773773
#'
774774
#' @param text string, description of the error that occurred,
775-
#' will be passed to \code{\link{glue}}.
776-
#' @param ... additional inputs for text passed to the \code{\link{glue}} function.
775+
#' will be passed to \code{\link[glue]{glue}}.
776+
#' @param ... additional inputs for text passed to the \code{\link[glue]{glue}} function.
777777
#' @param .envir the environment used to find the text string replacements
778778
#' @param output type of the output, can either a string (\code{"cli"}
779779
#' to use the \code{cli} package (default), \code{"R"} for

cran-comments.md

+10-27
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,19 @@
1-
This revision has small fixes addressing recently posted issue on the Github repo.
1+
This revision has fixes addressing issues posted on the Github repo. It is a reasonably small update.
22

33
## Test environment
44

5-
* R version 4.3.3 (2024-02-29 ucrt)
5+
Checks made using the GitHub Actions at https://github.com/rjournal/rjtools/blob/main/.github/workflows/R-CMD-check.yaml
66

7-
── R CMD check results ───────────────── rjtools 1.0.14 ────
8-
Duration: 24.2s
7+
It checks against the latest release: R version 4.4.2 (2024-10-31) -- "Pile of Leaves" for
8+
- macOS-latest
9+
- ubuntu-latest
10+
- windows-latest
11+
12+
── R CMD check results ────────────────────────────────────── rjtools 1.0.17 ────
13+
Duration: 34.7s
914

1015
0 errors ✔ | 0 warnings ✔ | 0 notes ✔
1116

12-
* winbuilder
17+
and using R CMD CHECK results in
1318

14-
Installation time in seconds: 7
15-
Check time in seconds: 65
1619
Status: OK
17-
18-
19-
With check_rhub, there are two notes, which I believe can be ignored.
20-
21-
── rjtools 1.0.12: NOTE
22-
23-
Build ID: rjtools_1.0.12.tar.gz-0420bebe3d074a298f5056193567f16e
24-
Platform: Windows Server 2022, R-devel, 64 bit
25-
Submitted: 2h 53m 53.5s ago
26-
Build time: 6m 12.7s
27-
28-
❯ checking for non-standard things in the check directory ... NOTE
29-
Found the following files/directories:
30-
''NULL''
31-
32-
❯ checking for detritus in the temp directory ... NOTE
33-
Found the following files/directories:
34-
'lastMiKTeXException'
35-
36-
0 errors ✔ | 0 warnings ✔ | 2 notes ✖

man/checks.Rd

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/log_error.Rd

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/testthat/test-check.R

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ test_that("check abstract works", {
4949
expect_true(check_abstract_str(str))
5050

5151
# others
52-
str <- "Highlight with \\texttt{xxx()} is not allowed"
52+
str <- "Highlight with \\texttt{person(2025)} is not allowed"
5353
expect_true(check_abstract_str(str))
54-
str <- "neither is \\emph{sdkfjls}"
54+
str <- "neither is \\emph{sdkfjls} allowed"
5555
expect_true(check_abstract_str(str))
5656
str <- "but emphasize that this is allowed"
5757
expect_false(check_abstract_str(str))

0 commit comments

Comments
 (0)