fix(frontend): do not show tokens button if not on namespace page

[NathanFlurry]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
rivet-inspector	Error			Dec 1, 2025 2:00pm
rivetkit-serverless	Error			Dec 1, 2025 2:00pm

2 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
rivet-cloud	Ignored			Dec 1, 2025 2:00pm
rivet-site	Ignored	Preview		Dec 1, 2025 2:00pm

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat(examples): add user-generated-actors example #3560
• feat(frontend): create api key #3556
• fix(frontend): do not show tokens button if not on namespace page #3558 👈 (View in Graphite)
• fix(frontend): update env vars for dev #3557
• docs: clean up last few missing pieces of content #3538
• main

---

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review: fix(frontend): do not show tokens button if not on namespace page

Summary

This PR conditionally renders the "Tokens" menu item in the user dropdown based on whether the user is on a namespace page. The change is straightforward and accomplishes its stated goal.

---

✅ Positive Aspects

1. Clear intent: The fix correctly restricts the "Tokens" button to only appear on namespace pages
2. Consistent pattern: Follows the existing pattern used for the "Billing" menu item (lines 101-112)
3. Clean implementation: Uses useMatchRoute with fuzzy matching appropriately

---

🔍 Code Quality Observations

Minor: Ternary with null alternative

Location: frontend/src/app/user-dropdown.tsx:68-79

The code uses a ternary with : null which is idiomatic but slightly verbose:

{isMatchingNamespaceRoute ? (
  <DropdownMenuItem>...</DropdownMenuItem>
) : null}

Suggestion: Consider using the && operator for consistency with other conditional renders in the file (e.g., lines 80, 89, 114):

{isMatchingNamespaceRoute && (
  <DropdownMenuItem>...</DropdownMenuItem>
)}

This is a minor style preference, but it matches the pattern used elsewhere in the same component.

---

🤔 Questions & Considerations

1. Route matching scope: The match uses fuzzy: true, which means it will match the namespace route and all its child routes. Is this the intended behavior? For example, will it match:

   • /orgs/$organization/projects/$project/ns/$namespace ✓
   • /orgs/$organization/projects/$project/ns/$namespace/connect ✓ (due to fuzzy)
   • /ns/$namespace (engine route) - Will this match? Should it?

2. Engine namespace route: Looking at the route tree, there's also an engine-specific namespace route at /ns/$namespace. Should the Tokens button also appear there, or is it intentionally Cloud-only?

---

📝 routeTree.gen.ts Changes

The frontend/src/routeTree.gen.ts file shows 941 lines changed (470 additions, 471 deletions), but these appear to be:

• Formatting changes (double quotes to single quotes)
• Import reordering
• Indentation changes (tabs to spaces)

Note: This is a generated file (see warning on line 8-9), so these changes are expected and safe to ignore. They likely resulted from running the route generation script.

---

🧪 Testing Recommendations

1. Verify the Tokens button appears:

   • On /orgs/$organization/projects/$project/ns/$namespace ✓
   • On /orgs/$organization/projects/$project/ns/$namespace/connect (if intended)

2. Verify the Tokens button does NOT appear:

   • On /orgs/$organization
   • On /orgs/$organization/projects/$project
   • On other routes outside the namespace context

3. Test the tokens modal:

   • Ensure clicking "Tokens" still opens the correct modal
   • Verify the modal functions correctly when opened from the namespace page

---

🔒 Security & Performance

• ✅ No security concerns identified
• ✅ No performance impact - simple conditional render
• ✅ No new dependencies added

---

📊 Overall Assessment

Status: ✅ Looks good to merge

This is a clean, focused fix that accomplishes its goal. The only minor suggestion is style consistency with the conditional rendering pattern. The generated route tree changes are expected and can be ignored.

Risk Level: Low
Complexity: Low

---

Review generated by Claude Code