Skip to content

Commit 9d0e6e0

Browse files
committed
Sdtrig: Clarify that tinfo.version is a global constant, not per-trigger
The purpose of "tinfo.version" field is apparently to describe the version of the whole Sdtrig implementation. That is, it is a constant unaffected by the current value of tselect CSR. Judging form the original commit that introduced it (0374fd6) and from the related mailing list discussion (https://lists.riscv.org/g/tech-debug/topic/96888390). However, the sentences `This register provides access to the trigger selected by tselect. The reset values listed here apply to every underlying trigger.` leave certain room for interpretation that "tinfo.version" is a per-trigger constant, not a global one, and could therefore change depending on "tselect". Remove this ambiguity by rewording the description of "tinfo" CSR and "tinfo.version" field.
1 parent bcd05b7 commit 9d0e6e0

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

xml/hwbp_registers.xml

+9-6
Original file line numberDiff line numberDiff line change
@@ -166,8 +166,9 @@ same project unless stated otherwise.
166166
</register>
167167

168168
<register name="Trigger Info" short="tinfo" address="0x7a4">
169-
This register provides access to the trigger selected by {csr-tselect}.
170-
The reset values listed here apply to every underlying trigger.
169+
This register provides information about the implemented version of
170+
the Sdtrig extension, and about the trigger types supported by
171+
the trigger selected by {csr-tselect}.
171172

172173
This register is optional if no triggers are implemented, or if
173174
{tdata1-type} is not writable and {tinfo-version} would be 0. In
@@ -176,7 +177,9 @@ same project unless stated otherwise.
176177

177178
<field name="0" bits="XLEN-1:32" access="R" reset="0" />
178179
<field name="version" bits="31:24" access="R" reset="Preset">
179-
Contains the version of the Sdtrig extension implemented.
180+
Contains the version of the Sdtrig extension implemented. The read-only
181+
value of this field refers to the implemented version of the whole
182+
Sdtrig extension, and is unaffected by the value of {csr-tselect}.
180183
<value v="0" name="0">
181184
Supports triggers as described in this spec at commit 5a5c078,
182185
made on February 2, 2023.
@@ -195,9 +198,9 @@ same project unless stated otherwise.
195198
</field>
196199
<field name="0" bits="23:16" access="R" reset="0" />
197200
<field name="info" bits="15:0" access="R" reset="Preset">
198-
One bit for each possible {tdata1-type} enumerated in {csr-tdata1}. Bit N
199-
corresponds to type N. If the bit is set, then that type is
200-
supported by the currently selected trigger.
201+
One bit for each possible {tdata1-type} enumerated in {csr-tdata1}.
202+
Bit N corresponds to type N. If the bit is set, then that type is
203+
supported by the currently selected trigger (by {csr-tselect}).
201204

202205
If the currently selected trigger doesn't exist, this field
203206
contains 1.

0 commit comments

Comments
 (0)