Skip to content

Commit ca86e70

Browse files
authored
Merge pull request #19 from rhythmictech/remove_additional_pkgs
move additional packages var to setup/teardown modules
2 parents 1725c28 + 0798c4f commit ca86e70

File tree

3 files changed

+8
-16
lines changed

3 files changed

+8
-16
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,6 @@ This module bridges the gap allowing Terraform to create EC2 Image Builder compo
112112
| component\_version | Version of the component | `string` | n/a | yes |
113113
| name | name to use for component | `string` | n/a | yes |
114114
| playbook\_repo | git url for repo where ansible code lives with provisioning playbook and requirements file<br>can append with `-b BRANCH_NAME` to clone a specific branch | `string` | n/a | yes |
115-
| additional\_packages | Space separate list of additional packages that may be needed for your ansible | `string` | `""` | no |
116115
| change\_description | description of changes since last version | `string` | `null` | no |
117116
| cloudformation\_timeout | How long to wait (in minutes) for CFN to apply before giving up | `number` | `10` | no |
118117
| data\_uri | Use this to override the component document with one at a particualar URL endpoint | `string` | `null` | no |

main.tf

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,14 @@ locals {
33
latest_component_minor_version = "${split(".", var.component_version)[0]}.${split(".", var.component_version)[1]}.x"
44

55
data = templatefile("${path.module}/component.yml.tpl", {
6-
additional_pkgs = var.additional_packages
7-
description = var.description
8-
name = var.name
9-
playbook_dir = var.playbook_dir
10-
playbook_file = var.playbook_file
11-
playbook_repo = var.playbook_repo
12-
repo_host = try(local.repo_parts.host, null)
13-
repo_port = coalesce(local.repo_parts.port, 22)
14-
ssh_key_name = try(data.aws_secretsmanager_secret.ssh_key[0].name, null)
6+
description = var.description
7+
name = var.name
8+
playbook_dir = var.playbook_dir
9+
playbook_file = var.playbook_file
10+
playbook_repo = var.playbook_repo
11+
repo_host = try(local.repo_parts.host, null)
12+
repo_port = coalesce(local.repo_parts.port, 22)
13+
ssh_key_name = try(data.aws_secretsmanager_secret.ssh_key[0].name, null)
1514
})
1615

1716
repo_parts = try(

variables.tf

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,3 @@
1-
variable "additional_packages" {
2-
default = ""
3-
description = "Space separate list of additional packages that may be needed for your ansible"
4-
type = string
5-
}
6-
71
variable "change_description" {
82
default = null
93
description = "description of changes since last version"

0 commit comments

Comments
 (0)