Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make adaptabuild a submodule #72

Open
rhempel opened this issue Feb 8, 2025 · 0 comments
Open

Make adaptabuild a submodule #72

rhempel opened this issue Feb 8, 2025 · 0 comments

Comments

@rhempel
Copy link
Owner

rhempel commented Feb 8, 2025

Currently the CI pipeline has to build an environment that allows adaptabuild to create the umm_malloc library and test it.
This is a potential source of problems because we need to keep umm_malloc in sync with changes to adaptabuild - or maintain backwards compatibility in adaptabuild.
The adaptabuild system isn't very big (~100K) so we can avoid problems by simply including it as a submodule of umm-malloc - then we are guaranteed to be able to build and test umm_malloc even if adaptabuild advances.
The downside is that larger projects that use adaptabuild and have umm_malloc as a dependency could have multiple (possibly conflicting) copies of adaptabuild. For any top level project, we specify one (and only one) adaptabuild folder. This is usually in the root of the project. Even if there are additional adaptabuild folders further down in the tree, they are invisible to the top layer adpatabuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant