Merge pull request pypa#3205 from xavfernandez/traceback_format_exc

Fix traceback.format_exc call

Author: xavfernandez

pip/req/req_install.py

@@ -344,11 +344,11 @@ def setup_py(self):
         assert self.source_dir, "No source dir for %s" % self
         try:
             import setuptools  # noqa
-        except ImportError as e:
+        except ImportError:
             if get_installed_version('setuptools') is None:
                 add_msg = "Please install setuptools."
             else:
-                add_msg = traceback.format_exc(e)
+                add_msg = traceback.format_exc()
             # Setuptools is not available
             raise InstallationError(
                 "Could not import setuptools which is required to "

tests/functional/test_install.py

@@ -30,6 +30,32 @@ def test_without_setuptools(script, data):
         "source distribution."
         in result.stderr
     )
+    assert "Please install setuptools" in result.stderr
+
+
+def test_with_setuptools_and_import_error(script, data):
+    # Make sure we get an ImportError while importing setuptools
+    setuptools_init_path = script.site_packages_path.join(
+        "setuptools", "__init__.py")
+    with open(setuptools_init_path, 'a') as f:
+        f.write('\nraise ImportError("toto")')
+
+    result = script.run(
+        "python", "-c",
+        "import pip; pip.main(["
+        "'install', "
+        "'INITools==0.2', "
+        "'-f', '%s', "
+        "'--no-binary=:all:'])" % data.packages,
+        expect_error=True,
+    )
+    assert (
+        "Could not import setuptools which is required to install from a "
+        "source distribution."
+        in result.stderr
+    )
+    assert "Traceback " in result.stderr
+    assert "ImportError: toto" in result.stderr
 
 
 def test_pip_second_command_line_interface_works(script, data):