Skip to content
This repository was archived by the owner on Mar 24, 2023. It is now read-only.

Commit c38a4f7

Browse files
authored
Merge pull request #637 from dexhorthy/overlay-copy
Update overlay/patch terminology
2 parents e0bc575 + 557e810 commit c38a4f7

File tree

2 files changed

+15
-16
lines changed

2 files changed

+15
-16
lines changed

web/init/src/components/kustomize/kustomize_overlay/KustomizeEmpty.jsx

+6-7
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ export default class KustomizeEmpty extends React.Component {
77
return (
88
<div className="KustomizeEmpty--wrapper flex1 flex-column EmmptyState--wrapper">
99
<div className="flex-1-auto u-overflow--auto container u-paddingTop--30 u-paddingBottom--30">
10-
<p className="u-fontSize--jumbo u-color--tuna u-fontWeight--bold u-marginBottom--normal u-lineHeight--normal">Kustomize your YAML with overlays</p>
10+
<p className="u-fontSize--jumbo u-color--tuna u-fontWeight--bold u-marginBottom--normal u-lineHeight--normal">Kustomize your YAML with patches</p>
1111
<p className="u-fontSize--normal u-fontWeight--medium u-lineHeight--more">
12-
An overlay is a target that modifies (and thus depends on) another target. The kustomization in an overlay refers to (via file path, URI or other method)
13-
some other kustomization, known as its base. Overlays make the most sense when there is more than one, because they create different variants of a common base
12+
A patch is an asset that modifies (and thus depends on) another asset. The kustomization in an overlay refers to (via file path, URI or other method)
13+
some other kustomization, known as its base. An overlay is a collections of patches. Overlays allow you to create different variants of a common base
1414
- e.g. development, QA, staging and production environment variants.
1515
</p>
1616
<div className="product-features-wrapper">
@@ -20,7 +20,7 @@ export default class KustomizeEmpty extends React.Component {
2020
<div className="feature-block">
2121
<div className="icon u-selectBaseIcon"></div>
2222
<p className="title">Select a base file</p>
23-
<p>Start by select a base file from the tree to the left. Files that typically use overlays are service.yaml and deployment.yaml</p>
23+
<p>Start by selecting a base file from the tree to the left. Files that typically use patches are services and deployments.</p>
2424
</div>
2525
</div>
2626
</div>
@@ -38,16 +38,15 @@ export default class KustomizeEmpty extends React.Component {
3838
<div className="feature-block">
3939
<div className="icon u-shipItIcon"></div>
4040
<p className="title">Ship your rendered YAML</p>
41-
<p>We do the heavy lifting to merge your overlays with the base YAML and give you a single YAML file for deployment.</p>
41+
<p>We do the heavy lifting to merge your patches with the base YAML and give you a single YAML file for deployment.</p>
4242
</div>
4343
</div>
4444
</div>
4545
</div>
4646
</div>
4747
<div className="skip-wrapper">
4848
<p className="u-fontSize--normal u-fontWeight--medium u-lineHeight--more">
49-
You are not required to customize your YAML. We built this tool to make it easy to apply overlay values and ship customized YAML quickly and effeciently. However, if you have no need to change any of these files you can move right along to the deployment step.
50-
</p>
49+
You are not required to customize your YAML. We built this tool to make it easy to apply patches and ship customized YAML quickly and effeciently. However, if you have no need to change any of these files you can move right along to the deployment step. </p>
5150
<p className="u-marginTop--20 u-fontSize--normal u-fontWeight--medium u-lineHeight--more">If you’re ready to deploy your YAML simply <span onClick={this.props.skipKustomize} className="u-color--astral u-textDecoration--underlineOnHover">click here</span>.</p>
5251
</div>
5352
</div>

web/init/src/components/kustomize/kustomize_overlay/KustomizeOverlay.jsx

+9-9
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ export default class KustomizeOverlay extends React.Component {
271271
<div className="flex1 flex-column">
272272
<div className="u-paddingLeft--20 u-paddingRight--20 u-paddingTop--20">
273273
<p className="u-marginBottom--normal u-fontSize--large u-color--tuna u-fontWeight--bold">Base YAML</p>
274-
<p className="u-fontSize--small u-lineHeight--more u-fontWeight--medium u-color--doveGray">Select a file to be used as the base YAML. You can then click the edit icon on the top right to create an overlay for that file.</p>
274+
<p className="u-fontSize--small u-lineHeight--more u-fontWeight--medium u-color--doveGray">Select a file to be used as the base YAML. You can then click the edit icon on the top right to create a patch for that file.</p>
275275
</div>
276276
{ selectedFile !== "" ?
277277
<div className="flex1 file-contents-wrapper AceEditor--wrapper">
@@ -280,7 +280,7 @@ export default class KustomizeOverlay extends React.Component {
280280
<span className="icon clickable u-overlayCreateIcon"></span>
281281
</div>
282282
}
283-
<ReactTooltip id="create-overlay-tooltip" effect="solid" className="replicated-tooltip">Create overlay</ReactTooltip>
283+
<ReactTooltip id="create-overlay-tooltip" effect="solid" className="replicated-tooltip">Create patch</ReactTooltip>
284284
<AceEditorHOC
285285
handleGeneratePatch={this.handleGeneratePatch}
286286
fileToView={fileToView}
@@ -300,13 +300,13 @@ export default class KustomizeOverlay extends React.Component {
300300

301301
<div className={`flex-column flex1 overlays-editor-wrapper ${showOverlay ? "visible" : ""}`}>
302302
<div className="u-paddingLeft--20 u-paddingRight--20 u-paddingTop--20">
303-
<p className="u-marginBottom--normal u-fontSize--large u-color--tuna u-fontWeight--bold">Overlay</p>
304-
<p className="u-fontSize--small u-lineHeight--more u-fontWeight--medium u-color--doveGray">This YAML will be applied as an overlay to the base YAML. Edit the values that you want overlayed. The current file you're editing will be automatically save when you open a new file.</p>
303+
<p className="u-marginBottom--normal u-fontSize--large u-color--tuna u-fontWeight--bold">Patch</p>
304+
<p className="u-fontSize--small u-lineHeight--more u-fontWeight--medium u-color--doveGray">This YAML will be applied as a patch to the base YAML. Edit the values that you want patched. The current file you're editing will be automatically saved when you open a new file.</p>
305305
</div>
306306
<div className="flex1 flex-column file-contents-wrapper u-position--relative">
307307
<div className="flex1 AceEditor--wrapper">
308308
{showOverlay && <span data-tip="close-overlay-tooltip" data-for="close-overlay-tooltip" className="icon clickable u-closeOverlayIcon" onClick={() => this.toggleModal(this.state.selectedFile)}></span>}
309-
<ReactTooltip id="close-overlay-tooltip" effect="solid" className="replicated-tooltip">Discard overlay</ReactTooltip>
309+
<ReactTooltip id="close-overlay-tooltip" effect="solid" className="replicated-tooltip">Discard patch</ReactTooltip>
310310
<AceEditor
311311
ref={this.setAceEditor}
312312
mode="yaml"
@@ -355,11 +355,11 @@ export default class KustomizeOverlay extends React.Component {
355355
<button type="button" onClick={this.props.skipKustomize} className="btn primary">Continue</button>
356356
:
357357
<div className="flex">
358-
<button type="button" disabled={dataLoading.saveKustomizeLoading || patch === "" || savingFinalize} onClick={() => this.handleKustomizeSave(false)} className="btn primary u-marginRight--normal">{dataLoading.saveKustomizeLoading && !savingFinalize ? "Saving overlay" : "Save overlay"}</button>
358+
<button type="button" disabled={dataLoading.saveKustomizeLoading || patch === "" || savingFinalize} onClick={() => this.handleKustomizeSave(false)} className="btn primary u-marginRight--normal">{dataLoading.saveKustomizeLoading && !savingFinalize ? "Saving patch" : "Save patch"}</button>
359359
{patch === "" ?
360360
<button type="button" onClick={this.props.skipKustomize} className="btn primary">Continue</button>
361361
:
362-
<button type="button" disabled={dataLoading.saveKustomizeLoading || savingFinalize} onClick={() => this.handleKustomizeSave(true)} className="btn secondary">{savingFinalize ? "Finalizing overlays" : "Save & continue"}</button>
362+
<button type="button" disabled={dataLoading.saveKustomizeLoading || savingFinalize} onClick={() => this.handleKustomizeSave(true)} className="btn secondary">{savingFinalize ? "Finalizing overlay" : "Save & continue"}</button>
363363
}
364364
</div>
365365
}
@@ -378,13 +378,13 @@ export default class KustomizeOverlay extends React.Component {
378378
className="Modal DefaultSize"
379379
>
380380
<div className="Modal-header">
381-
<p>Are you sure you want to discard this overlay?</p>
381+
<p>Are you sure you want to discard this patch?</p>
382382
</div>
383383
<div className="flex flex-column Modal-body">
384384
<p className="u-fontSize--large u-fontWeight--normal u-color--dustyGray u-lineHeight--more">It will not be applied to the kustomization.yaml file that is generated for you.</p>
385385
<div className="flex justifyContent--flexEnd u-marginTop--20">
386386
<button className="btn secondary u-marginRight--10" onClick={() => this.toggleModal("")}>Cancel</button>
387-
<button type="button" className="btn primary" onClick={this.discardOverlay}>Discard overlay</button>
387+
<button type="button" className="btn primary" onClick={this.discardOverlay}>Discard patch</button>
388388
</div>
389389
</div>
390390

0 commit comments

Comments
 (0)