Merge pull request #970 from laverya/improve-no-files-found-github-error-message

laverya · web-flow · commit 72726052e5f2 · 2019-06-12T15:50:14.000-07:00
include repo, path, ref in 'no files found' github asset error
diff --git a/pkg/lifecycle/render/github/render.go b/pkg/lifecycle/render/github/render.go
@@ -104,7 +104,7 @@ func (r *LocalRenderer) Execute(
 					return errors.Wrap(err, "resolveNoProxyGithubAssets")
 				}
 			} else {
-				return errors.New("github asset returned no files")
+				return fmt.Errorf("github asset %s returned no files in %s at %s", asset.Repo, asset.Path, asset.Ref)
 			}
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ func (r *LocalRenderer) Execute(`
`104`	`104`	`return errors.Wrap(err, "resolveNoProxyGithubAssets")`
`105`	`105`	`}`
`106`	`106`	`} else {`
`107`		`- return errors.New("github asset returned no files")`
	`107`	`+ return fmt.Errorf("github asset %s returned no files in %s at %s", asset.Repo, asset.Path, asset.Ref)`
`108`	`108`	`}`
`109`	`109`	`}`
`110`	`110`