Skip to content
This repository was archived by the owner on Mar 24, 2023. It is now read-only.

Commit 6dbeb95

Browse files
Merge pull request #714 from 10Dimensional/master
Hide helm name behind advanced settings toggle
2 parents 89362b1 + 9678160 commit 6dbeb95

File tree

3 files changed

+29
-2
lines changed

3 files changed

+29
-2
lines changed

web/init/src/components/kustomize/HelmReleaseNameInput.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export default class HelmReleaseNameInput extends React.Component {
1313
const { value } = this.props;
1414

1515
return (
16-
<div className={`field field-type-text container u-marginTop--15`}>
16+
<div className={`field field-type-text u-marginTop--15`}>
1717
<ConfigItemTitle
1818
title="Helm Name"
1919
/>

web/init/src/components/kustomize/HelmValuesEditor.jsx

+10-1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ export default class HelmValuesEditor extends React.Component {
2626
unsavedChanges: false,
2727
initialHelmReleaseName: "",
2828
helmReleaseName: "",
29+
displaySettings: false
2930
}
3031
}
3132

@@ -150,6 +151,7 @@ export default class HelmValuesEditor extends React.Component {
150151
helmLintErrors,
151152
initialHelmReleaseName,
152153
helmReleaseName,
154+
displaySettings
153155
} = this.state;
154156
const {
155157
values,
@@ -159,14 +161,21 @@ export default class HelmValuesEditor extends React.Component {
159161

160162
return (
161163
<ErrorBoundary>
162-
<HelmReleaseNameInput value={helmReleaseName} onChange={this.handleOnChangehelmReleaseName} />
163164
<div className="flex-column flex1 HelmValues--wrapper u-paddingTop--30">
164165
<div className="flex-column flex-1-auto u-overflow--auto container">
165166
<p className="u-color--dutyGray u-fontStize--large u-fontWeight--medium u-marginBottom--small">
166167
/{name}/
167168
<span className="u-color--tuna u-fontWeight--bold">values.yaml</span>
168169
</p>
169170
<p className="u-color--dustyGray u-fontSize--normal u-marginTop--normal u-marginBottom--20">Here you can edit the values.yaml to specify values for your application. You will be able to apply overlays for your YAML in the next step.</p>
171+
<div className="advanced-settings-wrapper u-marginTop--10">
172+
<div className={`section-border ${displaySettings ? "open" : "closed"} flex justifyContent--center u-position--relative`}>
173+
<p className="flex-auto u-fontSize--small u-color--tundora u-fontWeight--medium u-cursor--pointer" onClick={() => { this.setState({ displaySettings: !this.state.displaySettings }) }}>{displaySettings ? "Close Advanced Settings" : "Show Advanced Settings"}</p>
174+
</div>
175+
{displaySettings ? <div className="settings u-marginBottom--20">
176+
<HelmReleaseNameInput value={helmReleaseName} onChange={this.handleOnChangehelmReleaseName} />
177+
</div> : null}
178+
</div>
170179
<div className="AceEditor--wrapper helm-values flex1 flex u-height--full u-width--full">
171180
<div className="flex1 flex-column u-width--half">
172181
<AceEditor

web/init/src/scss/components/kustomize/HelmValuesEditor.scss

+18
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,22 @@
1717
left: 0;
1818
right: auto;
1919
}
20+
21+
}
22+
23+
.advanced-settings-wrapper {
24+
.section-border {
25+
border-bottom: 1px solid #DFDFDF;
26+
&.closed {
27+
margin-bottom: 35px;
28+
}
29+
& p {
30+
top: -13px;
31+
position: absolute;
32+
border: solid 1px #DFDFDF;
33+
border-radius: 50px;
34+
padding: 5px;
35+
background: #fff;
36+
}
37+
}
2038
}

0 commit comments

Comments
 (0)