Skip to content
This repository was archived by the owner on Mar 24, 2023. It is now read-only.

Commit 33e593f

Browse files
authored
Merge pull request #302 from GraysonNull/kustomize-merged-overlays
Kustomize merged overlays
2 parents f43ca56 + 65bf916 commit 33e593f

File tree

8 files changed

+13
-14
lines changed

8 files changed

+13
-14
lines changed

web/Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ serve_ship:
2323

2424
.state/build_ship: .state/package webpack* postcss* $(shell find src -type f)
2525
rm -rf dist
26-
`yarn bin`/webpack --config webpack.config.js --env ship --mode production
26+
`yarn bin`/webpack --config webpack.config.js --env production --mode production
2727
@mkdir -p .state
2828
@touch .state/build_ship
2929

web/env/production.js

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
module.exports = {
2+
ENVIRONMENT: "production",
3+
API_ENDPOINT: "/api/v1",
4+
WEBPACK_SCRIPTS: [
5+
"https://unpkg.com/react@16/umd/react.production.min.js",
6+
"https://unpkg.com/react-dom@16/umd/react-dom.production.min.js"
7+
]
8+
};

web/env/ship.js

-8
This file was deleted.

web/src/components/shared/Linter.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export default class Linter extends React.Component {
3232

3333
linkFor(error) {
3434
return error.links && error.links.length > 0 ? (
35-
<a target="_blank" href={error.links[0]}>
35+
<a target="_blank" href={error.links[0]} rel="noopener noreferrer">
3636
<span className={`icon u-linkIcon--blue flex-auto u-marginLeft--small clickable`}></span>
3737
</a>
3838
) : null;

web/src/components/shared/NavBar.jsx

-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ class NavBar extends React.Component {
4343

4444
getNavItems() {
4545
const token = true;
46-
4746
return[ !token ? null :
4847
{
4948
id: 0,

web/src/components/shared/NavItem.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export default class NavItem extends React.Component {
5353
return linkTo
5454
? <Link className={linkClassName} to={linkTo} tabIndex="-1">{linkContent}</Link>
5555
: href ?
56-
<a href={href} target="_blank" tabIndex="-1">{linkContent}</a>
56+
<a href={href} target="_blank" tabIndex="-1" rel="noopener noreferrer">{linkContent}</a>
5757
: options.isButton ?
5858
<button className={`Button ${options.buttonClassName || ""}`} tabIndex="-1">{linkContent}</button>
5959
: <a tabIndex="-1">{linkContent}</a>;

web/src/components/shared/PopoverItem.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export default class PopoverItem extends React.Component {
3030
{label}
3131
</Link>
3232
:
33-
<a className="PopoverLabel u-noSelect" href={href} target="_blank">
33+
<a className="PopoverLabel u-noSelect" href={href} target="_blank" rel="noopener noreferrer">
3434
{label}
3535
</a>
3636
}

web/webpack.config.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ module.exports = function (env) {
127127
} else if (env === "shipDev" || env === "configOnly") {
128128
var configEnv = require("./webpack.config.configOnly");
129129
return webpackMerge(common, configEnv);
130-
} else if (env === "ship") {
130+
} else if (env === "production") {
131131
var configEnv = require("./webpack.config.distConfigOnly");
132132
return webpackMerge(common, configEnv);
133133
} else {

0 commit comments

Comments
 (0)